Issue 205273003: Use toCSSFooValue() instaed of using static_cast<CSSFooValue*> in CSSValue.cpp

Issue 205273003: Use toCSSFooValue() instaed of using static_cast<CSSFooValue*> in CSSValue.cpp (Closed)

Created:
6 years, 9 months ago by gyuyoung-inactive

Modified:
6 years, 9 months ago

Reviewers:
Inactive

CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Use toCSSFooValue() instead of using static_cast<CSSFooValue*> in CSSValue.cpp Clean up static_cast<CSSFooValue*>. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169719

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -31 lines)			Patch
	M	Source/core/css/CSSValue.cpp	View		1 chunk	+31 lines, -31 lines	0 comments	Download

Total messages: 11 (0 generated)

Inactive

lgtm. Please fix "instaed" typo in the CL description before landing.

6 years, 9 months ago (2014-03-21 00:22:10 UTC) #2

gyuyoung-inactive

The CQ bit was checked by gyuyoung.kim@samsung.com

6 years, 9 months ago (2014-03-21 01:14:21 UTC) #3

gyuyoung-inactive

On 2014/03/21 00:22:10, Chris Dumez wrote: > lgtm. Please fix "instaed" typo in the CL ...

6 years, 9 months ago (2014-03-21 01:14:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/205273003/1

6 years, 9 months ago (2014-03-21 01:14:30 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-21 01:17:05 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on linux_blink_rel

6 years, 9 months ago (2014-03-21 01:17:05 UTC) #7

gyuyoung-inactive

The CQ bit was checked by gyuyoung.kim@samsung.com

6 years, 9 months ago (2014-03-21 03:51:20 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/205273003/10001

6 years, 9 months ago (2014-03-21 03:51:30 UTC) #9

gyuyoung-inactive

On 2014/03/21 01:17:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...

6 years, 9 months ago (2014-03-21 03:52:10 UTC) #10

Message was sent while issue was closed.

Change committed as 169719