rebaseline_server: image URLs are relative to JSON file's location

gm/rebaseline_server/static/loader.js

 /*
  * Loader:
  * Reads GM result reports written out by results.py, and imports
  * them into $scope.extraColumnHeaders and $scope.imagePairs .
  */
 var Loader = angular.module(
     'Loader',
     ['ConstantsModule']
 );
 
@@ skipping 146 matching lines @@
                                        [constants.KEY__VALUES_AND_COUNTS]);
 
           // Associative array of partial string matches per category.
           $scope.categoryValueMatch = {};
           $scope.categoryValueMatch.builder = "";
           $scope.categoryValueMatch.test = "";
 
           // If any defaults were overridden in the URL, get them now.
           $scope.queryParameters.load();
 
+          // All image URLs are relative to the JSON file's source directory.

[epoger, 2014/03/19 21:01:40]

Reason for the change: wherever we store the JSON summary, we have the *option*
of storing the images that go with it in nearby paths, and bundling all of the
files together (in a tarball, etc.), and then examining the results no matter
where we reconstitute the tarball.

Or the JSON can specify absolute paths as it has to date, that's fine too.

[borenet, 2014/03/20 13:05:05]

This seems inconsistent with the above comment, which says that they're all
relative (implying that absolute paths aren't allowed).

+          var baseUrlKey = constants.KEY__IMAGESETS__FIELD__BASE_URL;
+          angular.forEach(
+            $scope.imageSets,
+            function(imageSet) {
+              var baseUrl = imageSet[baseUrlKey];
+              if (!(baseUrl.substring(0, 1) === '/') &&
+                  !(baseUrl.substring(0, 5).toUpperCase() === 'HTTP:') &&
+                  !(baseUrl.substring(0, 6).toUpperCase() === 'HTTPS:')) {
+                imageSet[baseUrlKey] = $scope.resultsToLoad + '/../' + baseUrl;

[borenet, 2014/03/20 13:05:05]

Maybe move the above comment here and modify to something like: "Relative image
URLs are assumed to be relative to the JSON file's source directory."

+              }
+            }
+          );
+
           $scope.updateResults();
           $scope.loadingMessage = "";
           $scope.windowTitle = "Current GM Results";
         }
       }
     ).error(
       function(data, status, header, config) {
         $scope.loadingMessage = "FAILED to load.";
         $scope.windowTitle = "Failed to Load GM Results";
       }
@@ skipping 612 matching lines @@
      */
     $scope.getImageDiffRelativeUrl = function(imagePair) {
       var before =
           imagePair[constants.KEY__IMAGE_A_URL] + "-vs-" +
           imagePair[constants.KEY__IMAGE_B_URL];
       return before.replace(/[^\w\-]/g, "_") + ".png";
     }
 
   }
 );