rebaseline_server: image URLs are relative to JSON file's location

rebaseline_server: image URLs are relative to JSON file's location

BUG=skia:1455, skia:2230
NOTREECHECKS=True
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13874

[epoger, 2014-03-19 21:01:40]

Ready for review at patchset 1.

R=borenet since Ravi is out, but Ravi, if you're with us, feel free to review.

https://codereview.chromium.org/205273002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/205273002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:167: // All image URLs are relative to the
JSON file's source directory.
Reason for the change: wherever we store the JSON summary, we have the *option*
of storing the images that go with it in nearby paths, and bundling all of the
files together (in a tarball, etc.), and then examining the results no matter
where we reconstitute the tarball.

Or the JSON can specify absolute paths as it has to date, that's fine too.

[borenet, 2014-03-20 13:05:05]

https://codereview.chromium.org/205273002/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/loader.js (right):

https://codereview.chromium.org/205273002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:167: // All image URLs are relative to the
JSON file's source directory.
On 2014/03/19 21:01:40, epoger wrote:
> Reason for the change: wherever we store the JSON summary, we have the
*option*
> of storing the images that go with it in nearby paths, and bundling all of the
> files together (in a tarball, etc.), and then examining the results no matter
> where we reconstitute the tarball.
> 
> Or the JSON can specify absolute paths as it has to date, that's fine too.

This seems inconsistent with the above comment, which says that they're all
relative (implying that absolute paths aren't allowed).

https://codereview.chromium.org/205273002/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/loader.js:176: imageSet[baseUrlKey] =
$scope.resultsToLoad + '/../' + baseUrl;
Maybe move the above comment here and modify to something like: "Relative image
URLs are assumed to be relative to the JSON file's source directory."

[epoger, 2014-03-20 14:19:40]

Thanks, Eric.  Please see patchset 2.

[borenet, 2014-03-20 14:52:02]

LGTM

[epoger, 2014-03-20 15:27:23]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-03-20 15:27:29]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/205273002/20001

[commit-bot: I haz the power, 2014-03-20 15:27:36]

Change committed as 13874