Adding an interface to allow extention of the audio player for CRD and iOS.

remoting/client/chromoting_client.h

Index: remoting/client/chromoting_client.h
diff --git a/remoting/client/chromoting_client.h b/remoting/client/chromoting_client.h
index 704a672d7dd227bb086867bea8f12957cd2889b6..e3670009031e55e5d1497efe30f4a3b9ffe5a02b 100644
--- a/remoting/client/chromoting_client.h
+++ b/remoting/client/chromoting_client.h
@@ -36,8 +36,8 @@ class TransportContext;
 class VideoRenderer;
 }  // namespace protocol
 
+class AudioConsumer;
 class AudioDecodeScheduler;
-class AudioPlayer;
 class ClientContext;
 class ClientUserInterface;
 class FrameConsumerProxy;
@@ -47,12 +47,12 @@ class ChromotingClient : public SignalStrategy::Listener,
                          public protocol::ClientStub {
  public:
   // |client_context|, |user_interface| and |video_renderer| must outlive the
-  // client. |audio_player| may be null, in which case audio will not be
+  // client. |audio_consumer| may be null, in which case audio will not be
   // requested.
   ChromotingClient(ClientContext* client_context,
                    ClientUserInterface* user_interface,
                    protocol::VideoRenderer* video_renderer,
-                   std::unique_ptr<AudioPlayer> audio_player);
+                   AudioConsumer* audio_consumer);

[Sergey Ulanov, 2016/06/09 20:23:45]

pass ownership of the consumer here?

[nicholss, 2016/06/09 20:57:08]

It does not work for how I plan to use this for iOS is the problem. I need
something to hold on to the implementation of the audio player, not just to the
audio consumer interface. I was having a lot of issues with ownership of a
pointer pointing to a pure virtual class until I realized I need to have the
object held higher in the object stack.

 
   ~ChromotingClient() override;
 
@@ -102,7 +102,7 @@ class ChromotingClient : public SignalStrategy::Listener,
                       const protocol::TransportRoute& route) override;
 
  private:
-   // SignalStrategy::StatusObserver interface.
+  // SignalStrategy::StatusObserver interface.
   void OnSignalStrategyStateChange(SignalStrategy::State state) override;
   bool OnSignalStrategyIncomingStanza(const buzz::XmlElement* stanza) override;