Adding an interface to allow extention of the audio player for CRD and iOS.

remoting/client/audio_decode_scheduler_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
+#include "base/threading/thread.h"
+#include "remoting/base/auto_thread.h"
+#include "remoting/base/auto_thread_task_runner.h"
+#include "remoting/client/audio_decode_scheduler.h"

[Lambros, 2016/06/17 23:51:10]

Move this line above the other headers, with blank line separating. See
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

+#include "remoting/client/fake_audio_consumer.h"
+#include "remoting/protocol/session_config.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+const int kAudioSampleBytes = 4;
+const uint8_t kDummyAudioData = 0x8B;
+
+}  // namespace
+
+namespace remoting {
+
+class AudioDecodeSchedulerTest : public ::testing::Test {

[Lambros, 2016/06/17 23:51:10]

I don't see any EXPECTations anywhere, so very little is actually being tested
(you are only checking that the code doesn't actually crash).

You can follow up with another CL if it's a significant chunk of work to add
expectations (for example, if you need to write some mock classes).

+ public:
+  AudioDecodeSchedulerTest() {}
+
+  void SetUp() override;
+  void TearDown() override;
+
+ protected:
+  base::MessageLoop message_loop_;
+  base::RunLoop run_loop_;
+  scoped_refptr<AutoThreadTaskRunner> audio_decode_task_runner_;
+  scoped_refptr<AutoThreadTaskRunner> main_task_runner_;
+  std::unique_ptr<protocol::SessionConfig> session_config_;
+};
+
+void AudioDecodeSchedulerTest::SetUp() {
+  main_task_runner_ = new AutoThreadTaskRunner(message_loop_.task_runner(),
+                                               run_loop_.QuitClosure());
+  audio_decode_task_runner_ = AutoThread::Create("decode", main_task_runner_);
+  session_config_ = protocol::SessionConfig::ForTestWithAudio();
+}
+
+void AudioDecodeSchedulerTest::TearDown() {
+  // Release the task runners, so that the test can quit.
+  audio_decode_task_runner_ = nullptr;
+  main_task_runner_ = nullptr;
+
+  // Run the MessageLoop until everything has torn down.
+  run_loop_.Run();
+}
+
+// TODO(nicholss) could share the following in a common class for use

[Lambros, 2016/06/17 23:51:10]

Colon after TODO:
TODO(nicholss): Blah ...
Begin sentence with capital letter, end with period.
s/other/in other/ (or ".. for use elsewhere.")

[nicholss, 2016/06/20 17:47:51]

Thanks, sorry... I am use to the style of TODO:: Blah and I am over correcting
by removing both the :: :) fixed.

+// other places.
+std::unique_ptr<AudioPacket> CreatePacketWithSamplingRate_(
+    AudioPacket::SamplingRate rate,
+    int samples) {
+  std::unique_ptr<AudioPacket> packet(new AudioPacket());
+  packet->set_encoding(AudioPacket::ENCODING_RAW);
+  packet->set_sampling_rate(rate);
+  packet->set_bytes_per_sample(AudioPacket::BYTES_PER_SAMPLE_2);
+  packet->set_channels(AudioPacket::CHANNELS_STEREO);
+
+  // The data must be a multiple of 4 bytes (channels x bytes_per_sample).
+  std::string data;
+  data.resize(samples * kAudioSampleBytes, kDummyAudioData);
+  packet->add_data(data);
+
+  return packet;
+}
+
+std::unique_ptr<AudioPacket> CreatePacket44100Hz_(int samples) {
+  return CreatePacketWithSamplingRate_(AudioPacket::SAMPLING_RATE_44100,
+                                       samples);
+}
+
+std::unique_ptr<AudioPacket> CreatePacket48000Hz_(int samples) {
+  return CreatePacketWithSamplingRate_(AudioPacket::SAMPLING_RATE_48000,
+                                       samples);
+}
+
+TEST_F(AudioDecodeSchedulerTest, Shutdown) {
+  std::unique_ptr<FakeAudioConsumer> audio_consumer(new FakeAudioConsumer());
+  std::unique_ptr<AudioDecodeScheduler> audio_scheduler(
+      new AudioDecodeScheduler(main_task_runner_, audio_decode_task_runner_,
+                               audio_consumer->GetWeakPtr()));
+
+  audio_scheduler->Initialize(*session_config_);
+
+  audio_scheduler->ProcessAudioPacket(CreatePacket44100Hz_(1000),
+                                      base::Bind(&base::DoNothing));
+
+  audio_scheduler.reset();
+  audio_consumer.reset();
+}
+
+}  // namespace remoting