Adding an interface to allow extention of the audio player for CRD and iOS.

remoting/client/audio_consumer.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_CLIENT_AUDIO_CONSUMER_H_
+#define REMOTING_CLIENT_AUDIO_CONSUMER_H_
+
+#include <memory>
+
+namespace remoting {
+
+class AudioPacket;
+
+class AudioConsumer {
+ public:
+  virtual ~AudioConsumer() {};
+
+  virtual void AddAudioPacket(std::unique_ptr<AudioPacket> packet) = 0;
+
+ protected:
+  AudioConsumer() {};

[Lambros, 2016/06/15 22:13:49]

As this is an interface with pure virtual methods, I don't think you need to
declare a ctor? Try removing it - I think everything will still compile and
link.

[nicholss, 2016/06/15 22:42:47]

I removed it and got this:

../../remoting/client/audio_player.cc:18:14: error: constructor for
'remoting::AudioPlayer' must explicitly initialize the base class
'remoting::AudioConsumer' which does not have a default constructor
AudioPlayer::AudioPlayer()
             ^
../../remoting/client/audio_consumer.h:14:7: note: 'remoting::AudioConsumer'
declared here
class AudioConsumer {
      ^

[Lambros, 2016/06/17 18:32:29]

Guess you need to keep it then? :(

+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(AudioConsumer);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_CLIENT_AUDIO_CONSUMER_H_