Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2052713002: Remove the CryptoAPI implementation of SHA-1 (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the CryptoAPI implementation of SHA-1 There are no performance wins for using it, due to the overheads of acquiring a CryptoAPI/CNG context. Remove this codepath because it's not used nor maintained. BUG=none Committed: https://crrev.com/dbc5761e694dd2724ddba3d64afe6488e2a39f44 Cr-Commit-Position: refs/heads/master@{#398977}

Patch Set 1 #

Patch Set 2 : GN fix #

Patch Set 3 : Fix a few stragglers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -297 lines) Patch
M base/BUILD.gn View 1 2 chunks +1 line, -6 lines 0 comments Download
M base/base.gypi View 2 chunks +1 line, -5 lines 0 comments Download
A + base/sha1.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D base/sha1_portable.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D base/sha1_win.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/installer/mac/third_party/bsdiff/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mac/third_party/bsdiff/goobsdiff.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bootstrap/bootstrap.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052713002/1
4 years, 6 months ago (2016-06-08 23:55:31 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/174747) win8_chromium_ng on ...
4 years, 6 months ago (2016-06-09 00:02:49 UTC) #4
Ryan Sleevi
Brett: Would you mind taking a look at this? Both because it touches the GN ...
4 years, 6 months ago (2016-06-09 01:31:50 UTC) #6
brettw
lgtm
4 years, 6 months ago (2016-06-09 17:19:30 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052713002/40001
4 years, 6 months ago (2016-06-09 17:20:52 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 18:20:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052713002/40001
4 years, 6 months ago (2016-06-09 19:05:02 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 19:10:23 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 19:10:36 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:11:53 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dbc5761e694dd2724ddba3d64afe6488e2a39f44
Cr-Commit-Position: refs/heads/master@{#398977}

Powered by Google App Engine
This is Rietveld 408576698