Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/renderer_host/input/mouse_wheel_event_queue.cc

Issue 2052663004: Remove canScroll from WebMouseWheelEvent as it is unused now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/input/mouse_wheel_event_queue.cc
diff --git a/content/browser/renderer_host/input/mouse_wheel_event_queue.cc b/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
index 89a9f5a4e7f5d6058e2f753a26573d903d3f2222..26e9dc0c421d3c774a127cf427af6ced24df6eb0 100644
--- a/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
+++ b/content/browser/renderer_host/input/mouse_wheel_event_queue.cc
@@ -80,7 +80,8 @@ void MouseWheelEventQueue::ProcessMouseWheelAck(
// If event wasn't consumed then generate a gesture scroll for it.
if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED &&
- event_sent_for_gesture_ack_->event.canScroll &&
+ WebInputEventTraits::ShouldCauseScroll(
+ event_sent_for_gesture_ack_->event) &&
event_sent_for_gesture_ack_->event.resendingPluginId == -1 &&
(scrolling_device_ == blink::WebGestureDeviceUninitialized ||
scrolling_device_ == blink::WebGestureDeviceTouchpad)) {
« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | content/browser/web_contents/web_contents_impl_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698