Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: storage/browser/quota/quota_manager.h

Issue 2052663003: Move implementation of QuotaManager.getVolumeInfo to base::SysInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/quota/quota_manager.h
diff --git a/storage/browser/quota/quota_manager.h b/storage/browser/quota/quota_manager.h
index a1ef11d2a55fbdeb64aa37463f469d6fa92ef775..2d327241e22c1dc44071f6ba31c402e75e2557eb 100644
--- a/storage/browser/quota/quota_manager.h
+++ b/storage/browser/quota/quota_manager.h
@@ -97,7 +97,7 @@ class STORAGE_EXPORT QuotaEvictionHandler {
using UsageAndQuotaCallback = base::Callback<
void(QuotaStatusCode status, const UsageAndQuota& usage_and_quota)>;
using VolumeInfoCallback = base::Callback<
- void(bool success, uint64_t available_space, uint64_t total_space)>;
+ void(bool success, int64_t available_space, int64_t total_space)>;
// Returns next origin to evict. It might return an empty GURL when there are
// no evictable origins.
@@ -321,7 +321,7 @@ class STORAGE_EXPORT QuotaManager
// Function pointer type used to store the function which returns
// information about the volume containing the given FilePath.
using GetVolumeInfoFn = bool(*)(const base::FilePath&,
- uint64_t* available, uint64_t* total);
+ int64_t* available, int64_t* total);
typedef base::Callback<void(const QuotaTableEntries&)>
DumpQuotaTableCallback;
@@ -419,7 +419,7 @@ class STORAGE_EXPORT QuotaManager
void DidGetVolumeInfo(
const VolumeInfoCallback& callback,
- uint64_t* available_space, uint64_t* total_space, bool success);
+ int64_t* available_space, int64_t* total_space, bool success);
void GetLRUOrigin(StorageType type, const GetOriginCallback& callback);
@@ -455,9 +455,6 @@ class STORAGE_EXPORT QuotaManager
static int64_t CallGetAmountOfFreeDiskSpace(
GetVolumeInfoFn get_vol_info_fn,
const base::FilePath& profile_path);
- static bool GetVolumeInfo(const base::FilePath& path,
- uint64_t* available_space,
- uint64_t* total_size);
const bool is_incognito_;
const base::FilePath profile_path_;

Powered by Google App Engine
This is Rietveld 408576698