Move implementation of QuotaManager.getVolumeInfo to base::SysInfo.

base/sys_info_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <errno.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <string.h>
@@ skipping 77 matching lines @@
   return g_lazy_virtual_memory.Get().value();
 }
 
 // static
 int64_t SysInfo::AmountOfFreeDiskSpace(const FilePath& path) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   struct statvfs stats;
   if (HANDLE_EINTR(statvfs(path.value().c_str(), &stats)) != 0)
     return -1;
   return static_cast<int64_t>(stats.f_bavail) * stats.f_frsize;

[Dan Beam, 2016/06/09 17:20:13]

nit: maybe use GetDiskSpaceInfo() to implement AmountOfFreeDiskSpace?

int64_t available, unused;
if (!GetDiskSpaceInfo(path, &available, &unused))
  return -1;
return available;

OR

share the stat'ing code?

bool Stat(const char* path, statvfs* stats) {
  return HANDLE_EINTR(statvfs(path, stats)) != 0;
}

and from both

struct statvfs stats;
if (!Stat(path.value().c_str(), &stats))
  return false;  // or -1

[fukino, 2016/06/10 01:33:36]

Done.
I updated this to use GetDiskSpaceInfo() in AmountOfFreeDiskSpace.

 }
 
+// static
+bool SysInfo::GetDiskSpaceInfo(const FilePath& path,
+                               int64_t* available_bytes,
+                               int64_t* total_bytes) {
+  ThreadRestrictions::AssertIOAllowed();
+
+  struct statvfs stats;
+  if (HANDLE_EINTR(statvfs(path.value().c_str(), &stats)) != 0)
+    return false;
+
+  *available_bytes = static_cast<uint64_t>(stats.f_bavail) * stats.f_frsize;
+  *total_bytes = static_cast<uint64_t>(stats.f_blocks) * stats.f_frsize;
+  return true;
+}
+
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
 // static
 std::string SysInfo::OperatingSystemName() {
   struct utsname info;
   if (uname(&info) < 0) {
     NOTREACHED();
     return std::string();
   }
   return std::string(info.sysname);
 }
@@ skipping 26 matching lines @@
   }
   return arch;
 }
 
 // static
 size_t SysInfo::VMAllocationGranularity() {
   return getpagesize();
 }
 
 }  // namespace base