test/unittests/wasm/loop-assignment-analysis-unittest.cc - Issue 2052623003: [wasm] improve handling of malformed input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/wasm/loop-assignment-analysis-unittest.cc

Issue 2052623003: [wasm] improve handling of malformed input (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: use unsigned, terminate loop analysis on error, add unit test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/wasm/loop-assignment-analysis-unittest.cc

diff --git a/test/unittests/wasm/loop-assignment-analysis-unittest.cc b/test/unittests/wasm/loop-assignment-analysis-unittest.cc

index 7d97c5065e814284f1b956ffbcab0d90b6c22304..94d575710f89e1387b8a512befcf6d25b8148e95 100644

--- a/test/unittests/wasm/loop-assignment-analysis-unittest.cc

+++ b/test/unittests/wasm/loop-assignment-analysis-unittest.cc

@@ -180,6 +180,12 @@ TEST_F(WasmLoopAssignmentAnalyzerTest, Loop2) {

}

+TEST_F(WasmLoopAssignmentAnalyzerTest, Malformed) {

+ byte code[] = {kExprLoop, kExprF32Neg, kExprBrTable, 0x0e, "hello, world!"};

+ BitVector* assigned = Analyze(code, code + arraysize(code));

+ CHECK_NULL(assigned);

} // namespace wasm

} // namespace internal

} // namespace v8