Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2052613002: [Android, Settings] Fix NPE when both media related site settings are enabled (Closed)

Created:
4 years, 6 months ago by whywhat
Modified:
4 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@pause-when-unmute
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android, Settings] Fix NPE when both media related site settings are enabled Only look for AUTOPLAY preference if it's the only one enabled. BUG=618439 TEST=manual Committed: https://crrev.com/bf6c1f850a7b75b5992d3f99d7a8b3d8f0488b24 Cr-Commit-Position: refs/heads/master@{#398908}

Patch Set 1 #

Patch Set 2 : Rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052613002/1
4 years, 6 months ago (2016-06-08 20:31:28 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 22:25:42 UTC) #4
whywhat
PTaL
4 years, 6 months ago (2016-06-09 13:53:16 UTC) #6
Finnur
LGTM
4 years, 6 months ago (2016-06-09 15:44:23 UTC) #7
whywhat
Rebased on master
4 years, 6 months ago (2016-06-09 15:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052613002/20001
4 years, 6 months ago (2016-06-09 15:54:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 16:35:46 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 16:40:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf6c1f850a7b75b5992d3f99d7a8b3d8f0488b24
Cr-Commit-Position: refs/heads/master@{#398908}

Powered by Google App Engine
This is Rietveld 408576698