Chromium Code Reviews Chromium Code Reviews
Issue 20526007:
Create AJAX live-viewer of expected-vs-actual GM results (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/| Index: gm/viewer/view.html |
| =================================================================== |
| --- gm/viewer/view.html (revision 0) |
| +++ gm/viewer/view.html (revision 0) |
| @@ -0,0 +1,47 @@ |
| +<!DOCTYPE html> |
| + |
| +<html ng-app="JsonDataModule"> |
| + |
| +<head> |
| + <title>GM Expected-vs-Actual Results Display</title> |
| + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.min.js"></script> |
| + <script src="module.js"></script> |
| +</head> |
| + |
| +<body> |
| + <div ng-controller="JsonDataModule.Controller" > |
| + |
| + Pick a platform... |
| + <select ng-model="platformPath" ng-change="changePlatformPath()"> |
| + <option selected="selected">base-fake/Fake-Platform-Made-Up/base-fake</option> |
|
Zach Reizner
2013/07/29 18:40:34
Is the the plan to change this manually every time
epoger
2013/07/29 22:38:39
My plan is to populate this manually when I first
Zach Reizner
2013/07/30 13:41:13
I understand
|
| + <option>base-android-nexus-10/Test-Android-Nexus10-MaliT604-Arm7-Release/base-android-nexus-10</option> |
| + </select> |
| + |
| + <p> |
| + <h2>These are NOT live results. To get live results, copy view.html and module.js into |
| + <a href="https://code.google.com/p/skia-autogen/source/browse/#svn%2Fgm-actual">this</a> directory.</h2> |
| + Comparison of expected vs actual GM results for platform {{platformPath}}: |
| + |
| + <ul> |
| + <li ng-repeat="resultsOfOneType in actualResults"> |
|
Zach Reizner
2013/07/29 18:40:34
You could use a loop over rawJsonData['actual-resu
epoger
2013/07/29 22:38:39
That is actually what I originally had in place, w
Zach Reizner
2013/07/30 13:41:13
I see what you mean about too much logic inside th
epoger
2013/07/30 18:54:27
I suppose "straightforward" is a sliding scale. :-
|
| + <h3> |
| + {{resultsOfOneType['resultType']}} |
| + ({{resultsOfOneType['resultsOfThisType'].length}}) |
| + </h3> |
| + <table border="1"> |
| + <tr><th>Test/Config</th><th>Expected</th><th>Actual</th></tr> |
| + <tr ng-repeat="result in resultsOfOneType['resultsOfThisType']"> |
| + <td>{{result['imageName']}}</td> |
| + <td><a href="{{expectedResultsByImageName[result['imageName']]['url']}}"> |
|
epoger
2013/07/29 22:38:39
Regarding your suggestion to use a div popup when
Zach Reizner
2013/07/30 13:41:13
You can make the link always popup in a new tab. I
epoger
2013/07/30 18:54:27
Seems reasonable. I added target="_blank", so it
|
| + {{expectedResultsByImageName[result['imageName']]['hashValue']}} |
| + </a></td> |
| + <td><a href="{{result['url']}}">{{result['hashValue']}}</a></td> |
| + </tr> |
| + </table> |
| + <p> |
| + </li> |
| + </ul> |
| + </div> |
| + |
| +</body> |
| +</html> |
