Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 20526006: Remove -webkit-hyphens and -webkit-hyphenate-limit-* properties. (Closed)

Created:
7 years, 5 months ago by tony
Modified:
7 years, 4 months ago
Reviewers:
ojan
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, jeez
Visibility:
Public.

Description

Remove -webkit-hyphens and -webkit-hyphenate-limit-* properties. -webkit-hyphens was only partially implemented and the -webkit-hyphenate-limit-* properties help to control the unimplemented parts of -webkit-hyphens. We still support ­ (soft-hyphens) and -webkit-hyphenate-character. Test changes: - Rewrote hyphen-min-preferred-width to use ­ instead of -webkit-hyphens:auto. - Rewrote hyphenate-character.html so it's a reftest and uses ­. - Removed a -webkit-hyphens: none; test case from soft-hyphen-min-preferred-width.html. BUG=107111 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155171

Patch Set 1 #

Patch Set 2 : init removal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -1886 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/epub-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/epub-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/resources/property-names.js View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/css/parsing-hyphenate-limit.html View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/fast/css/parsing-hyphenate-limit-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/css/parsing-hyphenate-limit-lines.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/css/parsing-hyphenate-limit-lines-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/text/hyphen-min-preferred-width.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/text/hyphen-min-preferred-width-expected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/text/hyphenate-character.html View 2 chunks +5 lines, -42 lines 0 comments Download
A LayoutTests/fast/text/hyphenate-character-expected.html View 1 chunk +42 lines, -0 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-first-word.html View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/text/hyphenate-first-word-after-skipped-space.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-first-word-after-skipped-space-expected.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-first-word-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-limit-before-after.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-limit-before-after-expected.txt View 1 chunk +0 lines, -64 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-limit-lines.html View 1 chunk +0 lines, -51 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-limit-lines-expected.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/fast/text/hyphenate-locale.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/text/hyphens.html View 1 chunk +0 lines, -81 lines 0 comments Download
D LayoutTests/fast/text/hyphens-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
M LayoutTests/fast/text/soft-hyphen-min-preferred-width.html View 1 chunk +1 line, -12 lines 0 comments Download
M LayoutTests/fast/text/soft-hyphen-min-preferred-width-expected.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-character-expected.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-first-word-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-limit-before-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-limit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphenate-locale-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/text/hyphens-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphenate-first-word-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphenate-limit-before-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphenate-limit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphenate-locale-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/text/hyphens-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/text/hyphenate-locale-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/text/hyphens-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-character-expected.txt View 1 chunk +0 lines, -109 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-first-word-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-first-word-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-limit-before-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-limit-before-after-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-limit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-limit-lines-expected.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphens-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/text/hyphens-expected.txt View 1 chunk +0 lines, -99 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/text/hyphenate-character-expected.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/text/hyphens-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-character-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-character-expected.txt View 1 chunk +0 lines, -112 lines 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-first-word-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-limit-before-after-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-limit-lines-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-locale-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/text/hyphenate-locale-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win/fast/text/hyphens-expected.png View Binary file 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -16 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 4 chunks +0 lines, -17 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/core/platform/text/Hyphenation.h View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/core/platform/text/Hyphenation.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 8 chunks +4 lines, -81 lines 0 comments Download
M Source/core/rendering/RenderText.cpp View 6 chunks +4 lines, -79 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 3 chunks +0 lines, -11 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
There are mostly passing try jobs on patch set 1.
7 years, 5 months ago (2013-07-26 22:32:11 UTC) #1
ojan
lgtm
7 years, 4 months ago (2013-07-29 23:40:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/20526006/4001
7 years, 4 months ago (2013-07-30 17:42:54 UTC) #3
tony
7 years, 4 months ago (2013-07-30 19:17:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r155171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698