Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: ui/keyboard/keyboard_ui_handler.cc

Issue 20526005: Implement virtual keyboard hiding. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase and NOTREACHED Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_ui_handler.cc
diff --git a/ui/keyboard/keyboard_ui_handler.cc b/ui/keyboard/keyboard_ui_handler.cc
index 9d3920f57799a285c07b1309221ec0a57ff31475..85183018d752ead3f3e58c069f8cfdee50afe29f 100644
--- a/ui/keyboard/keyboard_ui_handler.cc
+++ b/ui/keyboard/keyboard_ui_handler.cc
@@ -17,6 +17,7 @@
#include "ui/aura/window.h"
#include "ui/base/ime/input_method.h"
#include "ui/base/ime/text_input_client.h"
+#include "ui/keyboard/keyboard_controller.h"
#include "ui/keyboard/keyboard_util.h"
namespace keyboard {
@@ -40,7 +41,10 @@ void KeyboardUIHandler::RegisterMessages() {
"sendKeyEvent",
base::Bind(&KeyboardUIHandler::HandleSendKeyEventMessage,
base::Unretained(this)));
-
+ web_ui()->RegisterMessageCallback(
+ "hideKeyboard",
+ base::Bind(&KeyboardUIHandler::HandleHideKeyboard,
+ base::Unretained(this)));
}
void KeyboardUIHandler::HandleInsertTextMessage(const base::ListValue* args) {
@@ -125,4 +129,11 @@ void KeyboardUIHandler::HandleSendKeyEventMessage(
}
}
+void KeyboardUIHandler::HandleHideKeyboard(const base::ListValue* args) {
+ // TODO(stevet): Call into the keyboard controller to hide the keyboard
+ // directly.
+ NOTREACHED();
sadrul 2013/09/12 18:58:04 NOTIMPLEMENTED() I believe NOTREACHED() is fatal
SteveT 2013/09/13 01:45:29 Sorry about the brain fart. :) Done.
+ return;
+}
+
} // namespace keyboard

Powered by Google App Engine
This is Rietveld 408576698