Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2052583003: Limit live Document tracking to debug builds. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit live Document tracking to debug builds. liveDocumentSet() is only used by a debug entry point, so only extend it on Document creation in debug builds. R= BUG=611702 Committed: https://crrev.com/34b125684e12b51bd77e16305b9162c347c7bc72 Cr-Commit-Position: refs/heads/master@{#398839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 4 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-09 09:23:30 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-09 09:31:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052583003/1
4 years, 6 months ago (2016-06-09 09:47:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 11:13:44 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 11:16:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34b125684e12b51bd77e16305b9162c347c7bc72
Cr-Commit-Position: refs/heads/master@{#398839}

Powered by Google App Engine
This is Rietveld 408576698