Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2052563002: Add Settings::useDefaultImageInterpolationQuality and use it in repaint tests (Closed)

Created:
4 years, 6 months ago by Xianzhu
Modified:
4 years, 6 months ago
Reviewers:
pdr., chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Settings::useDefaultImageInterpolationQuality and use it in repaint tests to enable reftests containing scaled images. BUG=611462 Committed: https://crrev.com/363e90a4d5917c294a2630346d0851ef1adc3bbc Cr-Commit-Position: refs/heads/master@{#398764}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebaseline some pixel tests containing scaled images #

Messages

Total messages: 19 (8 generated)
Xianzhu
4 years, 6 months ago (2016-06-08 18:28:10 UTC) #2
pdr.
Overall this sounds reasonable. https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js File third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js (right): https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js#newcode11 third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js:11: if (window.internals) Do we need ...
4 years, 6 months ago (2016-06-08 18:40:01 UTC) #3
Xianzhu
https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js File third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js (right): https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js#newcode11 third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js:11: if (window.internals) On 2016/06/08 18:40:01, pdr. wrote: > Do ...
4 years, 6 months ago (2016-06-08 18:41:24 UTC) #4
pdr.
On 2016/06/08 at 18:41:24, wangxianzhu wrote: > https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js > File third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js (right): > > https://codereview.chromium.org/2052563002/diff/1/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js#newcode11 ...
4 years, 6 months ago (2016-06-08 18:43:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052563002/1
4 years, 6 months ago (2016-06-08 18:48:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/241289)
4 years, 6 months ago (2016-06-08 21:11:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052563002/20001
4 years, 6 months ago (2016-06-08 21:18:58 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/225621)
4 years, 6 months ago (2016-06-08 22:42:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052563002/20001
4 years, 6 months ago (2016-06-09 02:18:12 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 02:50:24 UTC) #17
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 02:52:26 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/363e90a4d5917c294a2630346d0851ef1adc3bbc
Cr-Commit-Position: refs/heads/master@{#398764}

Powered by Google App Engine
This is Rietveld 408576698