Add Core::ReplaceHandleWithReducedRights().

mojo/edk/system/core_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/edk/system/core.h"
 
 #include <stdint.h>
 
 #include <limits>
 
@@ skipping 198 matching lines @@
   EXPECT_EQ(
       MOJO_RESULT_FAILED_PRECONDITION,
       core()->WaitMany(MakeUserPointer(&h), MakeUserPointer(&handle_signals), 1,
                        MOJO_DEADLINE_INDEFINITE, MakeUserPointer(&result_index),
                        MakeUserPointer(&hss)));
   EXPECT_EQ(9u, info.GetAddAwakableCallCount());
   EXPECT_EQ(0u, result_index);
   EXPECT_EQ(0u, hss.satisfied_signals);
   EXPECT_EQ(0u, hss.satisfiable_signals);
 
-  // |h| shares |info| with |h_dup|, which was closed above.
-  EXPECT_EQ(1u, info.GetDtorCallCount());
+  constexpr MojoHandleRights kRightsToRemove = MOJO_HANDLE_RIGHT_MAP_EXECUTABLE;
+  static_assert(kDefaultMockHandleRights & kRightsToRemove,
+                "Oops, reducing rights will be a no-op");
+  MojoHandle h_replacement = MOJO_HANDLE_INVALID;
+  EXPECT_EQ(MOJO_RESULT_OK,
+            core()->ReplaceHandleWithReducedRights(
+                h, kRightsToRemove, MakeUserPointer(&h_replacement)));
+  EXPECT_NE(h_replacement, MOJO_HANDLE_INVALID);
+  // This isn't guaranteed per se, but we count on handle values not being
+  // reused eagerly.
+  EXPECT_NE(h_replacement, h);
+  // |h| should be dead.
+  EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, core()->Close(h));
+  rights = MOJO_HANDLE_RIGHT_NONE;
+  EXPECT_EQ(MOJO_RESULT_OK,
+            core()->GetRights(h_replacement, MakeUserPointer(&rights)));
+  EXPECT_EQ(kDefaultMockHandleRights & ~kRightsToRemove, rights);
+
+  // |info| is shared between |h| (which was replaced, but not explicitly closed
+  // per se), |h_dup| (which was closed), and |h_replacement|.
+  EXPECT_EQ(2u, info.GetDtorCallCount());
   EXPECT_EQ(1u, info.GetCloseCallCount());
-  EXPECT_EQ(1u, info.GetCancelAllStateCallCount());
-  EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h));
-  EXPECT_EQ(2u, info.GetDtorCallCount());
+  EXPECT_EQ(2u, info.GetCancelAllStateCallCount());
+  EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h_replacement));
+  EXPECT_EQ(3u, info.GetDtorCallCount());
   EXPECT_EQ(2u, info.GetCloseCallCount());
-  EXPECT_EQ(2u, info.GetCancelAllStateCallCount());
+  EXPECT_EQ(3u, info.GetCancelAllStateCallCount());
 
   // No awakables should ever have ever been added.
   EXPECT_EQ(0u, info.GetRemoveAwakableCallCount());
 }
 
 TEST_F(CoreTest, InvalidArguments) {
   // |Close()|:
   {
     EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, core()->Close(MOJO_HANDLE_INVALID));
     EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT, core()->Close(10));
@@ skipping 12 matching lines @@
   {
     MojoHandleRights rights = MOJO_HANDLE_RIGHT_NONE;
     EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
               core()->GetRights(MOJO_HANDLE_INVALID, MakeUserPointer(&rights)));
     EXPECT_EQ(0u, rights);
     EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
               core()->GetRights(10, MakeUserPointer(&rights)));
     EXPECT_EQ(0u, rights);
   }
 
+  // |ReplaceHandleWithReducedRights()|:
+  {
+    MojoHandle h = MOJO_HANDLE_INVALID;
+    EXPECT_EQ(
+        MOJO_RESULT_INVALID_ARGUMENT,
+        core()->ReplaceHandleWithReducedRights(
+            MOJO_HANDLE_INVALID, MOJO_HANDLE_RIGHT_NONE, MakeUserPointer(&h)));
+    EXPECT_EQ(MOJO_HANDLE_INVALID, h);
+    EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
+              core()->ReplaceHandleWithReducedRights(10, MOJO_HANDLE_RIGHT_NONE,
+                                                     MakeUserPointer(&h)));
+    EXPECT_EQ(MOJO_HANDLE_INVALID, h);
+  }
+
   // |DuplicateHandleWithReducedRights()|:
   {
     MojoHandle h = MOJO_HANDLE_INVALID;
     EXPECT_EQ(
         MOJO_RESULT_INVALID_ARGUMENT,
         core()->DuplicateHandleWithReducedRights(
             MOJO_HANDLE_INVALID, MOJO_HANDLE_RIGHT_NONE, MakeUserPointer(&h)));
     EXPECT_EQ(MOJO_HANDLE_INVALID, h);
     EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
               core()->DuplicateHandleWithReducedRights(
@@ skipping 356 matching lines @@
   // |GetRights()|:
   {
     MockHandleInfo info;
     MojoHandle h = CreateMockHandle(&info);
     EXPECT_DEATH_IF_SUPPORTED(core()->GetRights(h, NullUserPointer()),
                               kMemoryCheckFailedRegex);
 
     EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h));
   }
 
+  // |ReplaceHandleWithReducedRights()|:
+  {
+    MockHandleInfo info;
+    MojoHandle h = CreateMockHandle(&info);
+    EXPECT_DEATH_IF_SUPPORTED(core()->ReplaceHandleWithReducedRights(
+                                  h, MOJO_HANDLE_RIGHT_NONE, NullUserPointer()),
+                              kMemoryCheckFailedRegex);
+
+    EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h));
+  }
+
   // |DuplicateHandleWithReducedRights()|:
   {
     MockHandleInfo info;
     MojoHandle h = CreateMockHandle(&info);
     EXPECT_DEATH_IF_SUPPORTED(core()->DuplicateHandleWithReducedRights(
                                   h, MOJO_HANDLE_RIGHT_NONE, NullUserPointer()),
                               kMemoryCheckFailedRegex);
 
     EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h));
   }
@@ skipping 1269 matching lines @@
 
   EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h));
 }
 
 // TODO(vtl): Test |CreateSharedBuffer()|, |DuplicateBufferHandle()|, and
 // |MapBuffer()|.
 
 }  // namespace
 }  // namespace system
 }  // namespace mojo