MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group> when controlled

chrome/browser/resources/settings/controls/settings_radio_group.js

Index: chrome/browser/resources/settings/controls/settings_radio_group.js
diff --git a/chrome/browser/resources/settings/controls/settings_radio_group.js b/chrome/browser/resources/settings/controls/settings_radio_group.js
index a9bc71dc07eca16fade086dd9b6e4a54868dce5b..b4b76fcab104741297c6daade946538100f5a923 100644
--- a/chrome/browser/resources/settings/controls/settings_radio_group.js
+++ b/chrome/browser/resources/settings/controls/settings_radio_group.js
@@ -15,9 +15,15 @@
 Polymer({
   is: 'settings-radio-group',
 
-  behaviors: [PrefControlBehavior],
+  behaviors: [CrPolicyPrefBehavior, PrefControlBehavior],
 
   properties: {
+    disabled_: {
+      observer: 'disabledChanged_',
+      type: Boolean,
+      value: false,
+    },
+
     /**
      * IronSelectableBehavior selected attribute.
      */
@@ -34,11 +40,22 @@ Polymer({
 
   /** @private */
   prefChanged_: function() {
+    this.disabled_ = this.isPrefPolicyControlled(this.pref);
     this.selected = Settings.PrefUtil.prefToString(
         /** @type {!chrome.settingsPrivate.PrefObject} */(this.pref));
   },
 
   /** @private */
+  disabledChanged_: function() {
+    if (this.disabled_) {

[michaelpg, 2016/06/08 19:23:16]

why does this assume policy is never reversed?

[Dan Beam, 2016/06/09 02:11:33]

it doesn't assume this, it was just trying not to stomp over a
<paper-radio-button> that's been disabled by other means.

if no component manages the disabled-ness of their <paper-radio-button>s, we're
probably fine to do disabled = false as well.

Pre-emptively changed to this (when disabled_ changes it stomps on children's
disabled attr)

+      var radioButtons = this.queryAllEffectiveChildren('paper-radio-button');
+      for (var i = 0; i < radioButtons.length; ++i) {
+        radioButtons[i].disabled = true;
+      }
+    }
+  },
+
+  /** @private */
   selectedChanged_: function(selected) {
     if (!this.pref)
       return;