MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group> when controlled

MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group> when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e92ee6c016fada60dc21950c4909a725cf80cd5b
Cr-Commit-Position: refs/heads/master@{#399029}

[Dan Beam, 2016-06-08 18:10:35]

Description was changed from

==========
DO NOT COMMIT

BUG=
==========

to

==========
DO NOT COMMIT

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-08 18:57:58]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-06-08 18:59:06]

Description was changed from

==========
DO NOT COMMIT

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-08 18:59:06]

dbeam@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Dan Beam, 2016-06-08 19:02:15]

before/after: http://imgur.com/a/UD38i

previous behavior is controls would look useful but clicking on other
<paper-radio-button>s than those enforced by policy would just fail to change
the effective setting

[Dan Beam, 2016-06-08 19:02:53]

Description was changed from

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-06-08 19:03:09]

eh, i should also write a simple test for this

[michaelpg, 2016-06-08 19:23:16]

https://codereview.chromium.org/2052543002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_radio_group.js (right):

https://codereview.chromium.org/2052543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_radio_group.js:50: if
(this.disabled_) {
why does this assume policy is never reversed?

[Dan Beam, 2016-06-09 02:06:39]

Patchset #2 (id:40001) has been deleted

[Dan Beam, 2016-06-09 02:11:34]

https://codereview.chromium.org/2052543002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_radio_group.js (right):

https://codereview.chromium.org/2052543002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_radio_group.js:50: if
(this.disabled_) {
On 2016/06/08 19:23:16, michaelpg wrote:
> why does this assume policy is never reversed?

it doesn't assume this, it was just trying not to stomp over a
<paper-radio-button> that's been disabled by other means.

if no component manages the disabled-ness of their <paper-radio-button>s, we're
probably fine to do disabled = false as well.

Pre-emptively changed to this (when disabled_ changes it stomps on children's
disabled attr)

[Dan Beam, 2016-06-09 02:11:43]

(also added a test)

[michaelpg, 2016-06-09 03:54:54]

little things

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/radio_group_tests.js (right):

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:22: // Import
settings_checkbox.html before running suite.
fix

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:28: // Initialize a checked
settings-checkbox before each test.
fix

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:37: testElement.innerHTML =
'<paper-radio-button></paper-radio-button>';
i'd prefer:

testElement.appendChild(document.createElement('paper-radio-button'));

instead of directly messing with HTML

[Dan Beam, 2016-06-09 04:53:37]

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/radio_group_tests.js (right):

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:22: // Import
settings_checkbox.html before running suite.
On 2016/06/09 03:54:54, michaelpg wrote:
> fix

Done.

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:28: // Initialize a checked
settings-checkbox before each test.
On 2016/06/09 03:54:54, michaelpg wrote:
> fix

Done.

https://codereview.chromium.org/2052543002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/radio_group_tests.js:37: testElement.innerHTML =
'<paper-radio-button></paper-radio-button>';
On 2016/06/09 03:54:54, michaelpg wrote:
> i'd prefer:
> 
> testElement.appendChild(document.createElement('paper-radio-button'));
> 
> instead of directly messing with HTML

Done.

[michaelpg, 2016-06-09 05:02:03]

asdf lgtm

[Dan Beam, 2016-06-09 21:00:20]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-06-09 21:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052543002/100001

[commit-bot: I haz the power, 2016-06-09 22:03:52]

Description was changed from

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-09 22:03:53]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-06-09 22:03:55]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-09 22:05:18]

Description was changed from

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: disable <paper-radio-button>s inside of a <settings-radio-group>
when controlled

This does not yet add UI for showing that the radio group is controlled.

R=michaelpg@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e92ee6c016fada60dc21950c4909a725cf80cd5b
Cr-Commit-Position: refs/heads/master@{#399029}
==========

[commit-bot: I haz the power, 2016-06-09 22:05:20]

Patchset 4 (id:??) landed as
https://crrev.com/e92ee6c016fada60dc21950c4909a725cf80cd5b
Cr-Commit-Position: refs/heads/master@{#399029}