Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2052523002: Add a trace-event for each runtime-stats timer (Closed)

Created:
4 years, 6 months ago by fmeawad
Modified:
4 years, 5 months ago
Reviewers:
Camillo Bruni
CC:
nednguyen, lpy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. BUG=v8:5089 Committed: https://crrev.com/44ec143f26769bd103662643bfeafc7d0834cc90 Cr-Commit-Position: refs/heads/master@{#36909}

Patch Set 1 #

Patch Set 2 : Move the event from behind the flag #

Patch Set 3 : v8.runtime_call --> v8.runtime #

Patch Set 4 : Make the runtime call trace behind a global flag #

Patch Set 5 : Use 'x' events for better performance. (it reduces memory pressure) #

Total comments: 4

Patch Set 6 : "Function" --> #Function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M src/api.cc View 1 2 3 4 10 chunks +11 lines, -0 lines 0 comments Download
M src/api-arguments.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M src/api-arguments-inl.h View 1 2 3 4 5 5 chunks +5 lines, -0 lines 0 comments Download
M src/counters.h View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M src/execution.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments Download
M src/tracing/trace-event.h View 1 2 3 4 2 chunks +23 lines, -0 lines 0 comments Download
M src/tracing/trace-event.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052523002/80001
4 years, 6 months ago (2016-06-11 21:44:32 UTC) #3
fmeawad
PTAL
4 years, 6 months ago (2016-06-11 21:58:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-11 22:15:00 UTC) #7
Camillo Bruni
LGTM with comments. BTW, we still have all the tracing events disabled for runtime functions ...
4 years, 6 months ago (2016-06-12 12:33:35 UTC) #8
fmeawad
https://codereview.chromium.org/2052523002/diff/80001/src/api-arguments-inl.h File src/api-arguments-inl.h (right): https://codereview.chromium.org/2052523002/diff/80001/src/api-arguments-inl.h#newcode23 src/api-arguments-inl.h:23: TRACE_RUNTIME_CALL("Function"); \ On 2016/06/12 12:33:35, Camillo Bruni wrote: > ...
4 years, 6 months ago (2016-06-12 15:52:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052523002/100001
4 years, 6 months ago (2016-06-12 15:53:12 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 6 months ago (2016-06-12 16:20:27 UTC) #14
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/44ec143f26769bd103662643bfeafc7d0834cc90 Cr-Commit-Position: refs/heads/master@{#36909}
4 years, 6 months ago (2016-06-12 16:21:27 UTC) #16
Benedikt Meurer
4 years, 6 months ago (2016-06-13 04:19:33 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2064553002/ by bmeurer@chromium.org.

The reason for reverting is: Seems to break TSAN, see
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10057.

Powered by Google App Engine
This is Rietveld 408576698