device/bluetooth/bluetooth_remote_gatt_service_mac.h - Issue 2052513002: Read characteristic implementation on macOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_service_mac.h

Issue 2052513002: Read characteristic implementation on macOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@characteristicscan_servicescan_cleanup

Patch Set: Addressing msarda's comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc ('k') | device/bluetooth/bluetooth_remote_gatt_service_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_service_mac.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_service_mac.h b/device/bluetooth/bluetooth_remote_gatt_service_mac.h

index 43679495d189ba89fa1595e96cee9276fd25d912..cec954745a01aa7ffd90dc04b27a267dfa73e4b1 100644

--- a/device/bluetooth/bluetooth_remote_gatt_service_mac.h

+++ b/device/bluetooth/bluetooth_remote_gatt_service_mac.h

@@ -23,7 +23,6 @@ class BluetoothAdapterMac;

class BluetoothDevice;

class BluetoothRemoteGattCharacteristicMac;

class BluetoothLowEnergyDeviceMac;

-class BluetoothTestMac;

class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattServiceMac

: public BluetoothRemoteGattService {

@@ -46,14 +45,18 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattServiceMac

const std::string& identifier) const override;

private:

- friend BluetoothLowEnergyDeviceMac;

- friend BluetoothTestMac;

+ friend class BluetoothLowEnergyDeviceMac;

+ friend class BluetoothRemoteGattCharacteristicMac;

+ friend class BluetoothTestMac;

// Starts discovering characteristics by calling CoreBluetooth.

void DiscoverCharacteristics();

// Called by the BluetoothLowEnergyDeviceMac instance when the characteristics

// has been discovered.

void DidDiscoverCharacteristics();

+ // Called by the BluetoothRemoteGattServiceMac instance when the

+ // characteristics value has been read.

+ void DidUpdateValue(CBCharacteristic* characteristic, NSError* error);

// Returns true if the characteristics has been discovered.

bool IsDiscoveryComplete();