Read characteristic implementation on macOS

device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm

Index: device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm
diff --git a/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm b/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm
index 19b628b720296e50b0e0564b030b321fa55ab39b..451a0c845392501270fdefa7674ea2476849a18e 100644
--- a/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm
+++ b/device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm
@@ -31,6 +31,10 @@ class BluetoothLowEnergyPeripheralBridge {
     device_mac_->DidDiscoverCharacteristics(service, error);
   };
 
+  void DidReadValue(CBCharacteristic* characteristic, NSError* error) {
+    device_mac_->DidReadValue(characteristic, error);
+  }
+
   CBPeripheral* GetPeripheral() { return device_mac_->GetPeripheral(); }
 
  private:
@@ -70,4 +74,10 @@ class BluetoothLowEnergyPeripheralBridge {
   bridge_->DidDiscoverCharacteristics(service, error);
 }
 
+- (void)peripheral:(CBPeripheral*)peripheral
+    didUpdateValueForCharacteristic:(CBCharacteristic*)characteristic
+                              error:(NSError*)error {
+  bridge_->DidReadValue(characteristic, error);

[ortuno, 2016/06/16 18:22:18]

We can't assume this a is Read Value result because
didUpdateValueForCharacteristic is also called for notifications :(

So you have to have some sort of logic to decide if you should call a readValue
callback or if you should just call GattCharacteristicChanged. I think this
should be done the Characteristic level. So the bridge's, device's and service's
methods should be called DidUpdateValueForCharacteristic. The characteristic
method should just be called DidUpdateValue.

[jlebel, 2016/06/22 18:03:58]

Done.

+}
+
 @end