device/bluetooth/bluetooth_low_energy_device_mac.mm - Issue 2052513002: Read characteristic implementation on macOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_low_energy_device_mac.mm

Issue 2052513002: Read characteristic implementation on macOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@characteristicscan_servicescan_cleanup

Patch Set: Removing ReadRemoteCharacteristic_AfterDeleted test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_low_energy_device_mac.h ('k') | device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm » ('j') | device/bluetooth/bluetooth_low_energy_peripheral_delegate.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_low_energy_device_mac.mm

diff --git a/device/bluetooth/bluetooth_low_energy_device_mac.mm b/device/bluetooth/bluetooth_low_energy_device_mac.mm

index 04c400a781bc86a8df6c9076b44e533b36c1cd95..2ddc592642cf448115309cd848f74bf2316ed580 100644

--- a/device/bluetooth/bluetooth_low_energy_device_mac.mm

+++ b/device/bluetooth/bluetooth_low_energy_device_mac.mm

@@ -312,6 +312,16 @@ void BluetoothLowEnergyDeviceMac::DidModifyServices(

[GetPeripheral() discoverServices:nil];

}

+void BluetoothLowEnergyDeviceMac::DidReadValue(CBCharacteristic* characteristic,

+ NSError* error) {

+ BluetoothRemoteGattServiceMac* gatt_service =

+ GetBluetoothRemoteGattService(characteristic.service);

+ if (!gatt_service) {

+ return;

+ }

+ gatt_service->DidReadValue(characteristic, error);

// static

std::string BluetoothLowEnergyDeviceMac::GetPeripheralIdentifier(

CBPeripheral* peripheral) {