Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2052473002: Revert of [webnfc] Implement push() method in blink nfc module. (Closed)

Created:
4 years, 6 months ago by xidachen
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@onionsoup_webnfc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [webnfc] Implement push() method in blink nfc module. (patchset #17 id:380001 of https://codereview.chromium.org/1708543002/ ) Reason for revert: The tests: nfc/mock-nfc.html nfc/push.html added by this CL timed out on these two bots: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/65781 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/18764 Original issue's description: > [webnfc] Implement push() method in blink nfc module. > > This patch implements nfc.push() and nfc.cancelPush() methods in nfc module. > > https://w3c.github.io/web-nfc/#dom-nfc-push > https://w3c.github.io/web-nfc/#dom-nfc-cancelpush > > Mock mojo service and simple layout test is added to validate input parameters > as well as conversion between WebNFC and corresponding mojo data structures. > > BUG=520391 > > Committed: https://crrev.com/5058e32db5582978f60a28bc0ccbeed0a7421283 > Cr-Commit-Position: refs/heads/master@{#398538} TBR=jochen@chromium.org,kenneth.christiansen@gmail.com,mikhail.pozdnyakov@intel.com,mlamouri@chromium.org,nick@chromium.org,reillyg@chromium.org,rijubrata.bhaumik@intel.com,rockot@chromium.org,tsepez@chromium.org,alexander.shalamov@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=520391 Committed: https://crrev.com/e8253395b514c1187f4615f3bcfc31b7b5d8b6b8 Cr-Commit-Position: refs/heads/master@{#398548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -1139 lines) Patch
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/nfc/nfc.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
M device/nfc/nfc.mojom View 2 chunks +3 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/nfc/mock-nfc.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/nfc/push.html View 1 chunk +0 lines, -170 lines 0 comments Download
D third_party/WebKit/LayoutTests/nfc/resources/nfc-helpers.js View 1 chunk +0 lines, -286 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/nfc/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.h View 3 chunks +7 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 3 chunks +14 lines, -528 lines 0 comments Download
D third_party/WebKit/Source/modules/nfc/NFCError.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/modules/nfc/NFCError.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCClient.h View 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCError.h View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCMessage.h View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCObserver.h View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCPushOptions.h View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCPushTarget.h View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/modules/nfc/WebNFCWatchOptions.h View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
xidachen
Created Revert of [webnfc] Implement push() method in blink nfc module.
4 years, 6 months ago (2016-06-08 14:38:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052473002/1
4 years, 6 months ago (2016-06-08 14:39:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 14:40:11 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 14:43:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8253395b514c1187f4615f3bcfc31b7b5d8b6b8
Cr-Commit-Position: refs/heads/master@{#398548}

Powered by Google App Engine
This is Rietveld 408576698