Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2097)

Unified Diff: chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc

Issue 205243014: Reenable WindowSizerContextMenuTest.OpenBrowserUsingContextMenuOnOtherDisplay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: disable on win as it used to be Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
diff --git a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
index 4e67c6c41ddc3ca951bf7b926ff17a3256968316..46374337d7dd99fac4033b3aa4a6da8620ad91a8 100644
--- a/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
+++ b/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
@@ -69,8 +69,10 @@ void OpenBrowserUsingShelfOnRootWindow(aura::Window* root_window) {
#if defined(OS_WIN)
#define MAYBE_OpenBrowserUsingShelfOnOtherDisplay DISABLED_OpenBrowserUsingShelfOnOtherDisplay
+#define MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay DISABLED_OpenBrowserUsingContextMenuOnOtherDisplay
#else
#define MAYBE_OpenBrowserUsingShelfOnOtherDisplay OpenBrowserUsingShelfOnOtherDisplay
+#define MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay OpenBrowserUsingContextMenuOnOtherDisplay
#endif
IN_PROC_BROWSER_TEST_F(WindowSizerTest,
@@ -161,9 +163,8 @@ void OpenBrowserUsingContextMenuOnRootWindow(aura::Window* root_window) {
} // namespace
-// Test is flaky: http://crbug.com/346799
IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
- DISABLED_OpenBrowserUsingContextMenuOnOtherDisplay) {
+ MAYBE_OpenBrowserUsingContextMenuOnOtherDisplay) {
// Don't shutdown when closing the last browser window.
chrome::IncrementKeepAliveCount();
@@ -174,14 +175,14 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
BrowserList* browser_list =
BrowserList::GetInstance(chrome::HOST_DESKTOP_TYPE_ASH);
- EXPECT_EQ(1u, browser_list->size());
+ ASSERT_EQ(1u, browser_list->size());
EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow());
CloseBrowser(browser_list->get(0));
OpenBrowserUsingContextMenuOnRootWindow(root_windows[1]);
// A new browser must be created on 2nd display.
- EXPECT_EQ(1u, browser_list->size());
+ ASSERT_EQ(1u, browser_list->size());
EXPECT_EQ(root_windows[1],
browser_list->get(0)->window()->GetNativeWindow()->GetRootWindow());
EXPECT_EQ(root_windows[1], ash::Shell::GetTargetRootWindow());
@@ -189,7 +190,7 @@ IN_PROC_BROWSER_TEST_F(WindowSizerContextMenuTest,
OpenBrowserUsingContextMenuOnRootWindow(root_windows[0]);
// Next new browser must be created on 1st display.
- EXPECT_EQ(2u, browser_list->size());
+ ASSERT_EQ(2u, browser_list->size());
EXPECT_EQ(root_windows[0],
browser_list->get(1)->window()->GetNativeWindow()->GetRootWindow());
EXPECT_EQ(root_windows[0], ash::Shell::GetTargetRootWindow());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698