Add chrome.webcamPrivate idl

Add chrome.webcamPrivate idl

This also adds the stubs for all the functions.

BUG=346492
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263287

[not at google - send to devlin, 2014-03-20 11:24:50]

https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/webcam_private.idl (right):

https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/webcam_private.idl:9: double? value;
what do these mean?

https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/webcam_private.idl:12: callback SuccessCallback =
void(boolean success);
typically success is implicit so long as it doesn't fail, and failure is
communicated via chrome.runtime.lastError.

https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/webcam_private.idl:33: static void
getCurrentPanZoomTilt(DOMString sourceId, PZTCallback callback);
you could also consider

dictionary WebcamParameters { ... }

dictionary WebcamConfiguration {
  optional double pan;
  optional double zoom;
  optional double tilt;
}

static void set(WebcamParameters, WebcamConfiguration, SuccessCallback);
static void get(WebcamParameters, WebcamConfigurationCallback);
static void reset(WebcamParameters, SuccessCallback);

[Zachary Kuznia, 2014-04-10 19:27:51]

On 2014/03/20 11:24:50, kalman wrote:
>
https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
> File chrome/common/extensions/api/webcam_private.idl (right):
> 
>
https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/webcam_private.idl:9: double? value;
> what do these mean?
> 
>
https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/webcam_private.idl:12: callback SuccessCallback =
> void(boolean success);
> typically success is implicit so long as it doesn't fail, and failure is
> communicated via chrome.runtime.lastError.
> 
>
https://codereview.chromium.org/205243005/diff/1/chrome/common/extensions/api...
> chrome/common/extensions/api/webcam_private.idl:33: static void
> getCurrentPanZoomTilt(DOMString sourceId, PZTCallback callback);
> you could also consider
> 
> dictionary WebcamParameters { ... }
> 
> dictionary WebcamConfiguration {
>   optional double pan;
>   optional double zoom;
>   optional double tilt;
> }
> 
> static void set(WebcamParameters, WebcamConfiguration, SuccessCallback);
> static void get(WebcamParameters, WebcamConfigurationCallback);
> static void reset(WebcamParameters, SuccessCallback);

I've modified the API per your feedback.  PTAL

[not at google - send to devlin, 2014-04-10 20:05:59]

the extensions-related code lgtm but I'm not comfortable reviewing stuff about
webcams, is there somebody else who can look at that?

https://codereview.chromium.org/205243005/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/webcam_private/webcam_private_api.cc (right):

https://codereview.chromium.org/205243005/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/webcam_private/webcam_private_api.cc:112:
result.zoom = make_scoped_ptr(new double(v4l2_ctrl.value));
result.zoom.reset(new double(..)) would be slightly more concise.

https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:459: "extension_types":
["extension", "platform_app", "legacy_packaged_app"],
you don't need extension_types here, that's already in permissions.

the other APIs shouldn't have extension_types in here either..

[Zachary Kuznia, 2014-04-10 20:18:42]

On 2014/04/10 20:05:59, kalman wrote:
> the extensions-related code lgtm but I'm not comfortable reviewing stuff about
> webcams, is there somebody else who can look at that?
> 
>
https://codereview.chromium.org/205243005/diff/20001/chrome/browser/extension...
> File chrome/browser/extensions/api/webcam_private/webcam_private_api.cc
(right):
> 
>
https://codereview.chromium.org/205243005/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/api/webcam_private/webcam_private_api.cc:112:
> result.zoom = make_scoped_ptr(new double(v4l2_ctrl.value));
> result.zoom.reset(new double(..)) would be slightly more concise.
> 
>
https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
> File chrome/common/extensions/api/_api_features.json (right):
> 
>
https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
> chrome/common/extensions/api/_api_features.json:459: "extension_types":
> ["extension", "platform_app", "legacy_packaged_app"],
> you don't need extension_types here, that's already in permissions.
> 
> the other APIs shouldn't have extension_types in here either..

Actually, I should probably separate the webcam code into a separate CL.  I'll
re-upload this one with just the function stubs.

[Zachary Kuznia, 2014-04-10 20:57:52]

I've updated the CL so it only contains extension code.

https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/205243005/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/_api_features.json:459: "extension_types":
["extension", "platform_app", "legacy_packaged_app"],
On 2014/04/10 20:06:00, kalman wrote:
> you don't need extension_types here, that's already in permissions.
> 
> the other APIs shouldn't have extension_types in here either..

Done.

[Zachary Kuznia, 2014-04-10 21:00:23]

Hi Ilya,

Could you do an OWNERS review of:
extensions/browser/extension_function_histogram_value.h

Thanks,
-Zach

[Ilya Sherman, 2014-04-10 21:26:14]

On 2014/04/10 21:00:23, Zachary Kuznia wrote:
> Hi Ilya,
> 
> Could you do an OWNERS review of:
> extensions/browser/extension_function_histogram_value.h
> 
> Thanks,
> -Zach

Please run the script under //tools/metrics/histograms to update histograms.xml
with your new enum entry.  Thanks!

[Zachary Kuznia, 2014-04-10 21:31:00]

On 2014/04/10 21:26:14, Ilya Sherman wrote:
> On 2014/04/10 21:00:23, Zachary Kuznia wrote:
> > Hi Ilya,
> > 
> > Could you do an OWNERS review of:
> > extensions/browser/extension_function_histogram_value.h
> > 
> > Thanks,
> > -Zach
> 
> Please run the script under //tools/metrics/histograms to update
histograms.xml
> with your new enum entry.  Thanks!

Done.

[Ilya Sherman, 2014-04-10 21:31:29]

LGTM, thanks.

[Zachary Kuznia, 2014-04-10 21:32:08]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-04-10 21:33:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/205243005/60001

[commit-bot: I haz the power, 2014-04-10 21:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 21:33:44]

Failed to apply patch for
extensions/browser/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/browser/extension_function_histogram_value.h
  Hunk #1 FAILED at 777.
  1 out of 1 hunk FAILED -- saving rejects to file
extensions/browser/extension_function_histogram_value.h.rej

Patch:       extensions/browser/extension_function_histogram_value.h
Index: extensions/browser/extension_function_histogram_value.h
diff --git a/extensions/browser/extension_function_histogram_value.h
b/extensions/browser/extension_function_histogram_value.h
index
63197b223a56de60df69f9030fc37b8cf6bc81e0..da3ba949f3ccc29d25c3670b723a1010eb70bb59
100644
--- a/extensions/browser/extension_function_histogram_value.h
+++ b/extensions/browser/extension_function_histogram_value.h
@@ -777,6 +777,9 @@ enum HistogramValue {
   FILESYSTEMPROVIDER_UNMOUNT,
   FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDSUCCESS,
   FILESYSTEMPROVIDERINTERNAL_UNMOUNTREQUESTEDERROR,
+  WEBCAMPRIVATE_SET,
+  WEBCAMPRIVATE_RESET,
+  WEBCAMPRIVATE_GET,
   // Last entry: Add new entries above and ensure to update
   // tools/metrics/histograms/histograms/histograms.xml.
   ENUM_BOUNDARY

[Zachary Kuznia, 2014-04-10 21:39:01]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-04-10 21:39:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/205243005/80001

[commit-bot: I haz the power, 2014-04-10 23:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 23:16:41]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Zachary Kuznia, 2014-04-11 01:25:35]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-04-11 01:26:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/205243005/80001

[commit-bot: I haz the power, 2014-04-11 02:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 02:33:34]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[Zachary Kuznia, 2014-04-11 15:31:40]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-04-11 15:32:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/205243005/100001

[commit-bot: I haz the power, 2014-04-11 18:25:06]

Change committed as 263287