Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Issue 2052423002: Add Dispatcher methods for wait sets. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Dispatcher methods for wait sets. (No wait set dispatcher implementation yet.) Also: * Add missing MOJO_CREATE_WAIT_SET_OPTIONS_FLAG_NONE definition. * Specify the rights required for the wait set operations. * Some other related preliminary work. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/fff6f55222438ea0ab130a0bcf65ecf27d0a5a6b

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -25 lines) Patch
M mojo/edk/system/dispatcher.h View 1 6 chunks +38 lines, -4 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 10 chunks +82 lines, -14 lines 0 comments Download
M mojo/edk/system/entrypoint_class.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/c/system/wait_set.h View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
viettrungluu
4 years, 6 months ago (2016-06-10 19:41:10 UTC) #2
vardhan
lgtm
4 years, 6 months ago (2016-06-10 20:04:43 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-10 20:07:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fff6f55222438ea0ab130a0bcf65ecf27d0a5a6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698