Issue 20524: Clean up WebKit resources after starting a download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20524: Clean up WebKit resources after starting a download (Closed)

Created:
11 years, 10 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clean up WebKit resources after starting a download. Downloads initiated in the renderer process have associated resources that need to be cleaned up properly. Since we handle downloads in the browser process, the renderer was not receiving the completion notification and thus hanging on to resources. We now send the renderer a completion notification once we detect that a resource request is a download, so that the renderer can properly clean up. BUG=6531 (http://crbug.com/6531) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10291

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/renderer_host/buffered_resource_handler.cc	View	1 2	1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 20524: Clean up WebKit resources after starting a download (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages