components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java - Issue 2052363002: Enable public key pinning of local trust anchors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2052363002: Enable public key pinning of local trust anchors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Ryan's comments + unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/CronetEngine.java ('K') | « components/cronet/android/test/cronet_url_request_context_config_test.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

index 95f35eed336afe712c640f82540cbb353600e2fb..b71f7a427067f11714b5b4f896f47b1191ded4a0 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

@@ -1110,6 +1110,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {

builder.setExperimentalOptions("ijkl");

builder.setDataReductionProxyOptions("mnop", "qrst", "uvwx");

builder.setStoragePath(CronetTestFramework.getTestStorage(getContext()));

+ builder.enablePublicKeyPinsForLocalTrustAnchors(true);

nativeVerifyUrlRequestContextConfig(

CronetUrlRequestContext.createNativeUrlRequestContextConfig(getContext(), builder),

CronetTestFramework.getTestStorage(getContext()));