Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: telemetry/telemetry/internal/browser/browser_unittest.py

Issue 2052353003: Adding utility methods to retrieve minidump paths from the browser. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Refactoring GetAllMinidumpPaths to check breakpad format when crashpad_database_util isn't present. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/browser/browser_unittest.py
diff --git a/telemetry/telemetry/internal/browser/browser_unittest.py b/telemetry/telemetry/internal/browser/browser_unittest.py
index 2769f1f6d81982801bfc00081e462fbef042cc09..d0cb6e9ec0600e9218342ff530fb708902ae12fb 100644
--- a/telemetry/telemetry/internal/browser/browser_unittest.py
+++ b/telemetry/telemetry/internal/browser/browser_unittest.py
@@ -9,6 +9,7 @@ import tempfile
import unittest
from telemetry.core import util
+from telemetry.core import exceptions
from telemetry import decorators
from telemetry.internal.browser import browser as browser_module
from telemetry.internal.browser import browser_finder
@@ -84,6 +85,16 @@ class BrowserTest(browser_test_case.BrowserTestCase):
original_tab.Close()
self.assertEqual(self._browser.foreground_tab, new_tab)
+ # This test uses the reference browser and doesn't have access to
+ # helper binaries like crashpad_database_util.
+ @decorators.Enabled('linux')
+ def testGetMinidumpPathOnCrash(self):
+ tab = self._browser.tabs[0]
+ with self.assertRaises(exceptions.AppCrashException):
+ tab.Navigate('chrome://crash', timeout=5)
+ crash_minidump_path = self._browser.GetMostRecentMinidumpPath()
+ self.assertIsNotNone(crash_minidump_path)
+
def testGetSystemInfo(self):
if not self._browser.supports_system_info:
logging.warning(
« no previous file with comments | « telemetry/telemetry/internal/browser/browser.py ('k') | telemetry/telemetry/internal/platform/android_platform_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698