Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2052353002: Route ScrollEvents to correct process under OOPIF (Closed)

Created:
4 years, 6 months ago by kenrb
Modified:
4 years, 6 months ago
Reviewers:
wjmaclean, Charlie Reis
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route ScrollEvents to correct process under OOPIF On ChromeOS, trackpad scroll events are not routed to the an OOPIF even when the mouse cursor is over one. This is because ScrollEvents are transformed to WheelEvents and then passed directly to the top-level frame's RenderWidgetHost, and don't use the path of other WheelEvents that invokes the RenderWidgetHostInputEventRouter for browser process hit testing. This CL causes the events generated on reception of a ScrollEvent by a RenderWidgetHostViewAura to be hit tested and sent to the appropriate RenderWidgetHostView. BUG=615445 Committed: https://crrev.com/0b678205722777a678aa0ae3a2610cae7a4efbce Cr-Commit-Position: refs/heads/master@{#401671}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Test added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 2 chunks +24 lines, -5 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 2 chunks +80 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
kenrb
Dave, I don't know if this is at all related to the bug you were ...
4 years, 6 months ago (2016-06-23 14:22:25 UTC) #2
kenrb
James: Does this look okay to you? You're probably the person with the most knowledge ...
4 years, 6 months ago (2016-06-23 16:28:57 UTC) #5
wjmaclean
On 2016/06/23 16:28:57, kenrb wrote: > James: Does this look okay to you? You're probably ...
4 years, 6 months ago (2016-06-23 16:49:28 UTC) #6
kenrb
Charlie can you take a pass for owner review? It adds another Aura-only test to ...
4 years, 6 months ago (2016-06-23 17:25:26 UTC) #8
Charlie Reis
LGTM!
4 years, 6 months ago (2016-06-23 17:37:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052353002/40001
4 years, 6 months ago (2016-06-23 17:52:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-23 19:07:58 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:11:09 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b678205722777a678aa0ae3a2610cae7a4efbce
Cr-Commit-Position: refs/heads/master@{#401671}

Powered by Google App Engine
This is Rietveld 408576698