Fix dead lock in isolate shutdown.

Fix dead lock in isolate shutdown.

The service isolate is shutdown after the application isolates, so that any blocking i/o requests by pending isolate spawn tasks can be handled.

BUG=#26684
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/bbe812f727418b9f2cc92f43bacce4035969008b

[Florian Schneider, 2016-06-10 21:45:21]

Description was changed from

==========
Fix dead lock in isolate shutdown.

BUG=#26684
==========

to

==========
Fix dead lock in isolate shutdown.

The service isolate is shutdown after the application isolates, so that any
blocking i/o requests by pending isolate spawn tasks can be handled.

BUG=#26684
==========

[Florian Schneider, 2016-06-10 21:45:38]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2016-06-10 21:51:07]

lgtm

If this bug is in 1.17 stable, then this fix should be included in the next
patch release.

https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc#newcode323
runtime/vm/dart.cc:323: ASSERT(Isolate::isolates_list_head_ ==
Dart::vm_isolate());
Is the VM isolate really guaranteed to be first?

[Florian Schneider, 2016-06-10 21:53:05]

https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc#newcode323
runtime/vm/dart.cc:323: ASSERT(Isolate::isolates_list_head_ ==
Dart::vm_isolate());
On 2016/06/10 21:51:07, zra wrote:
> Is the VM isolate really guaranteed to be first?

good point. I have to fix this assertion.

[Florian Schneider, 2016-06-10 21:54:08]

On 2016/06/10 21:51:07, zra wrote:
> lgtm
> 
> If this bug is in 1.17 stable, then this fix should be included in the next
> patch release.
> 

I don't think the new loader code is in 1.17 already. It was just added last
week.

> https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc
> File runtime/vm/dart.cc (right):
> 
>
https://codereview.chromium.org/2052343002/diff/1/runtime/vm/dart.cc#newcode323
> runtime/vm/dart.cc:323: ASSERT(Isolate::isolates_list_head_ ==
> Dart::vm_isolate());
> Is the VM isolate really guaranteed to be first?

[Florian Schneider, 2016-06-10 22:55:06]

Added check for service isolate running.

[Florian Schneider, 2016-06-10 23:00:21]

Description was changed from

==========
Fix dead lock in isolate shutdown.

The service isolate is shutdown after the application isolates, so that any
blocking i/o requests by pending isolate spawn tasks can be handled.

BUG=#26684
==========

to

==========
Fix dead lock in isolate shutdown.

The service isolate is shutdown after the application isolates, so that any
blocking i/o requests by pending isolate spawn tasks can be handled.

BUG=#26684
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bbe812f727418b9f2cc92f43bacce4035969008b
==========

[Florian Schneider, 2016-06-10 23:00:23]

Committed patchset #3 (id:40001) manually as
bbe812f727418b9f2cc92f43bacce4035969008b (presubmit successful).