Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2052333002: [iOS/GN] Convert .strings file to binary1 plist format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/copy_bundle_data.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 146744030c2e838f51fe3b71a9adc55c1e20f721..7807746f146f7dbeb49640e1c11fa912a0b3e95a 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -276,9 +276,14 @@ template("mac_toolchain") {
}
tool("copy_bundle_data") {
+ if (is_ios) {
+ _extra_args = "--strings-format=binary1"
+ } else {
+ _extra_args = ""
+ }
_tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py",
root_build_dir)
- command = "python $_tool {{source}} {{output}}"
+ command = "python $_tool ${_extra_args} {{source}} {{output}}"
description = "COPY_BUNDLE_DATA {{source}} {{output}}"
pool = ":bundle_pool($default_toolchain)"
}
« no previous file with comments | « no previous file | build/toolchain/mac/copy_bundle_data.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698