build/toolchain/mac/BUILD.gn - Issue 2052333002: [iOS/GN] Convert .strings file to binary1 plist format.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 2052333002: [iOS/GN] Convert .strings file to binary1 plist format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/mac/BUILD.gn

diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn

index 146744030c2e838f51fe3b71a9adc55c1e20f721..283f4011bbbd8dcd4b1a2660c0ef581ceb47a3de 100644

--- a/build/toolchain/mac/BUILD.gn

+++ b/build/toolchain/mac/BUILD.gn

@@ -276,9 +276,14 @@ template("mac_toolchain") {

}

tool("copy_bundle_data") {

+ if (is_ios) {

+ _extra_args = "--strings-format=binary1"

+ } else {

+ _extra_args = ""

+ }

_tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py",

root_build_dir)

- command = "python $_tool {{source}} {{output}}"

+ command = "python $_tool {{source}} {{output}} ${_extra_args}"

Robert Sesek 2016/06/13 16:50:57 Put this before {{source}} ?

sdefresne 2016/06/14 07:27:39 Done.

description = "COPY_BUNDLE_DATA {{source}} {{output}}"

pool = ":bundle_pool($default_toolchain)"

}

« no previous file with comments | « no previous file | build/toolchain/mac/copy_bundle_data.py » ('j') | build/toolchain/mac/copy_bundle_data.py » ('J')