Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Side by Side Diff: build/toolchain/mac/BUILD.gn

Issue 2052333002: [iOS/GN] Convert .strings file to binary1 plist format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/toolchain/mac/copy_bundle_data.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # TODO(brettw) Use "gcc_toolchain.gni" like the Linux toolchains. This requires 5 # TODO(brettw) Use "gcc_toolchain.gni" like the Linux toolchains. This requires
6 # some enhancements since the commands on Mac are slightly different than on 6 # some enhancements since the commands on Mac are slightly different than on
7 # Linux. 7 # Linux.
8 8
9 import("../goma.gni") 9 import("../goma.gni")
10 import("//build/config/ios/ios_sdk.gni") 10 import("//build/config/ios/ios_sdk.gni")
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 tool("stamp") { 269 tool("stamp") {
270 command = stamp_command 270 command = stamp_command
271 description = stamp_description 271 description = stamp_description
272 } 272 }
273 tool("copy") { 273 tool("copy") {
274 command = copy_command 274 command = copy_command
275 description = copy_description 275 description = copy_description
276 } 276 }
277 277
278 tool("copy_bundle_data") { 278 tool("copy_bundle_data") {
279 if (is_ios) {
280 _extra_args = "--strings-format=binary1"
281 } else {
282 _extra_args = ""
283 }
279 _tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py", 284 _tool = rebase_path("//build/toolchain/mac/copy_bundle_data.py",
280 root_build_dir) 285 root_build_dir)
281 command = "python $_tool {{source}} {{output}}" 286 command = "python $_tool ${_extra_args} {{source}} {{output}}"
282 description = "COPY_BUNDLE_DATA {{source}} {{output}}" 287 description = "COPY_BUNDLE_DATA {{source}} {{output}}"
283 pool = ":bundle_pool($default_toolchain)" 288 pool = ":bundle_pool($default_toolchain)"
284 } 289 }
285 tool("compile_xcassets") { 290 tool("compile_xcassets") {
286 _tool = rebase_path("//build/toolchain/mac/compile_xcassets.py", 291 _tool = rebase_path("//build/toolchain/mac/compile_xcassets.py",
287 root_build_dir) 292 root_build_dir)
288 if (is_ios) { 293 if (is_ios) {
289 _sdk_name = ios_sdk_name 294 _sdk_name = ios_sdk_name
290 _min_deployment_target = ios_deployment_target 295 _min_deployment_target = ios_deployment_target
291 } else { 296 } else {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 } 395 }
391 396
392 mac_toolchain("x64") { 397 mac_toolchain("x64") {
393 toolchain_cpu = "x64" 398 toolchain_cpu = "x64"
394 toolchain_os = "mac" 399 toolchain_os = "mac"
395 cc = "${goma_prefix}/gcc" 400 cc = "${goma_prefix}/gcc"
396 cxx = "${goma_prefix}/g++" 401 cxx = "${goma_prefix}/g++"
397 ld = cxx 402 ld = cxx
398 is_clang = false 403 is_clang = false
399 } 404 }
OLDNEW
« no previous file with comments | « no previous file | build/toolchain/mac/copy_bundle_data.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698