Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2052283002: Allow reactions to enqueue other reactions for the same element (Closed)

Created:
4 years, 6 months ago by kojii
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow reactions to enqueue other reactions for the same element When upgrade reactions[1] upgrade elements[2], it may enqueue callback reactions. This patch allows CustomElementReactionStack to enqueue() for the same element from within popInvokingReactions(). [1] https://html.spec.whatwg.org/multipage/scripting.html#upgrade-reaction [2] https://html.spec.whatwg.org/multipage/scripting.html#upgrades BUG=594918 Committed: https://crrev.com/f26af41b1664d9903b3357efed3de49db8914f75 Cr-Commit-Position: refs/heads/master@{#399480}

Patch Set 1 #

Patch Set 2 : minor typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/custom/CEReactionsScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStackTest.cpp View 1 1 chunk +44 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
kojii
PTAL. Required to enqueue callback reactions.
4 years, 6 months ago (2016-06-10 16:19:10 UTC) #3
kojii
dominicc has machine trouble, reviewed offline and said good to go with TBR.
4 years, 6 months ago (2016-06-13 04:01:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052283002/20001
4 years, 6 months ago (2016-06-13 04:01:21 UTC) #7
dominicc (has gone to gerrit)
lgtm
4 years, 6 months ago (2016-06-13 04:04:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237770)
4 years, 6 months ago (2016-06-13 07:47:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052283002/20001
4 years, 6 months ago (2016-06-13 08:07:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237809)
4 years, 6 months ago (2016-06-13 10:29:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052283002/20001
4 years, 6 months ago (2016-06-13 14:14:43 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 17:57:34 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 17:57:45 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 17:58:57 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f26af41b1664d9903b3357efed3de49db8914f75
Cr-Commit-Position: refs/heads/master@{#399480}

Powered by Google App Engine
This is Rietveld 408576698