Dump INFO CODE_ID containing Build ID in Linux dump_syms

Dump INFO CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/c44217f6468152bf5693df7ec78a48d97e2b0e83

[Ted Mielczarek, 2016-06-10 13:59:39]

Description was changed from

==========
Dump CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=
==========

to

==========
Dump INFO_CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=
==========

[Mark Mentovai, 2016-06-10 16:06:08]

LGTM

[Mark Mentovai, 2016-06-10 16:07:11]

Wait…do we need a corresponding processor change here?

[Ted Mielczarek, 2016-06-10 16:33:44]

On 2016/06/10 16:07:11, Mark Mentovai wrote:
> Wait…do we need a corresponding processor change here?

No, the Windows dump_syms has been outputting this info for a long time:
https://chromium.googlesource.com/breakpad/breakpad/+/67d5567177301d0c24303f2...

We already ignore lines starting with "INFO" in the symbol parser.

[Mark Mentovai, 2016-06-10 16:47:55]

The LGTM stands, then!

[Mark Mentovai, 2016-06-10 16:49:39]

Adjust CL description to remove the extra underscore.

[Ted Mielczarek, 2016-06-10 17:22:43]

Description was changed from

==========
Dump INFO_CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=
==========

to

==========
Dump INFO CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=
==========

[Ted Mielczarek, 2016-06-10 17:23:16]

On 2016/06/10 16:49:39, Mark Mentovai wrote:
> Adjust CL description to remove the extra underscore.

...and that was the result of me *editing* it because I realized I had forgotten
the "INFO" in the first place!

[Ted Mielczarek, 2016-06-10 17:23:34]

Description was changed from

==========
Dump INFO CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=
==========

to

==========
Dump INFO CODE_ID containing Build ID in Linux dump_syms

I'd like to have the Build ID available for our symbol server
uploading, and this will make it easy.

Most of this change is me rewriting dump_symbols_unittest to be
typed tests so I could add a new test there.

R=mark@chromium.org
BUG=

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/c44217f6468152bf5693df7...
==========

[Ted Mielczarek, 2016-06-10 17:23:36]

Committed patchset #2 (id:20001) manually as
c44217f6468152bf5693df7ec78a48d97e2b0e83 (presubmit successful).