Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2052243002: Do not apply NVIDIA driver workarounds to nouveau (Closed)

Created:
4 years, 6 months ago by Julien Isorce Samsung
Modified:
4 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0b88a0e65aac2d847756f76e35113bd4eb190ee7 Cr-Commit-Position: refs/heads/master@{#399676}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase and increment version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 6 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/1
4 years, 6 months ago (2016-06-10 12:50:50 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/1548)
4 years, 6 months ago (2016-06-10 15:37:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/20001
4 years, 6 months ago (2016-06-13 09:20:53 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 10:52:22 UTC) #11
Julien Isorce Samsung
On 2016/06/13 10:52:22, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-13 21:56:37 UTC) #12
Zhenyao Mo
lgtm https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.69", Please update this version.
4 years, 6 months ago (2016-06-13 22:47:04 UTC) #13
Julien Isorce Samsung
https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_bug_list_json.cc#newcode22 gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.69", On 2016/06/13 22:47:04, Zhenyao Mo wrote: > ...
4 years, 6 months ago (2016-06-14 07:50:28 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/40001
4 years, 6 months ago (2016-06-14 07:50:50 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 10:04:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/40001
4 years, 6 months ago (2016-06-14 10:18:10 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-14 10:21:55 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 10:21:57 UTC) #24
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 10:23:17 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b88a0e65aac2d847756f76e35113bd4eb190ee7
Cr-Commit-Position: refs/heads/master@{#399676}

Powered by Google App Engine
This is Rietveld 408576698