|
|
Created:
4 years, 6 months ago by Julien Isorce Samsung Modified:
4 years, 6 months ago CC:
chromium-reviews, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not apply NVIDIA driver workarounds to nouveau
For each modifed entry I verified that the initial bug
was reported against NVIDIA driver.
Also I have tested the CL with nouveau driver.
I have not changed entry 5 that adds workaround
'use_current_program_after_successful_link' because it seems to
be valid on old mesa drivers so it would require more investigation.
I have not changed entry 54 that add workaround
'clear_uniforms_before_first_program_use' because it seems to
be general policy applied to all gpu except on some osx.
BUG=505969
R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/0b88a0e65aac2d847756f76e35113bd4eb190ee7
Cr-Commit-Position: refs/heads/master@{#399676}
Patch Set 1 #Patch Set 2 : Rebase #
Total comments: 2
Patch Set 3 : Rebase and increment version #Messages
Total messages: 26 (13 generated)
Description was changed from ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, zmo@chromium.org ========== to ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/20001
Description was changed from ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
j.isorce@samsung.com changed reviewers: + piman@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/06/13 10:52:22, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Hi, plz have a look, thx.
lgtm https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.69", Please update this version.
https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2052243002/diff/20001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.69", On 2016/06/13 22:47:04, Zhenyao Mo wrote: > Please update this version. Ah right, thx.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2052243002/#ps40001 (title: "Rebase and increment version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243002/40001
Message was sent while issue was closed.
Description was changed from ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Do not apply NVIDIA driver workarounds to nouveau For each modifed entry I verified that the initial bug was reported against NVIDIA driver. Also I have tested the CL with nouveau driver. I have not changed entry 5 that adds workaround 'use_current_program_after_successful_link' because it seems to be valid on old mesa drivers so it would require more investigation. I have not changed entry 54 that add workaround 'clear_uniforms_before_first_program_use' because it seems to be general policy applied to all gpu except on some osx. BUG=505969 R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0b88a0e65aac2d847756f76e35113bd4eb190ee7 Cr-Commit-Position: refs/heads/master@{#399676} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0b88a0e65aac2d847756f76e35113bd4eb190ee7 Cr-Commit-Position: refs/heads/master@{#399676} |