Issue 2052223003: Enhance the tests for ComputeLibraryCycleTask

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2052223003: Enhance the tests for ComputeLibraryCycleTask (Closed)

Created:
4 years, 6 months ago by Brian Wilkerson

Modified:
4 years, 6 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	pkg/analyzer/test/src/task/dart_test.dart	View		7 chunks	+23 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

I think we already have tests that cover the scenario we were discussing yesterday, and ...

4 years, 6 months ago (2016-06-10 15:46:39 UTC) #2

Paul Berry

lgtm. Reflecting further on my assessment of the bug yesterday, I was mistaken. I agree ...

4 years, 6 months ago (2016-06-10 16:02:05 UTC) #3

Brian Wilkerson

4 years, 6 months ago (2016-06-10 16:55:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
776000aac4f606ff4da36bca328df5e05ca55513 (presubmit successful).