Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2052213002: Revert "Parse PopularSites JSON on iOS too." (Closed)

Created:
4 years, 6 months ago by sfiera
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Parse PopularSites JSON on iOS too." This reverts commit e4eb2a57c8667ab31903237e3c316fcaf4afe718. We'll switch to a callback after the move. BUG=603026 Committed: https://crrev.com/2f8b53fd1b00bc82609c731bfea77e50cd123d51 Cr-Commit-Position: refs/heads/master@{#399157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -47 lines) Patch
M chrome/browser/android/ntp/popular_sites.cc View 4 chunks +2 lines, -47 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sfiera
4 years, 6 months ago (2016-06-10 10:30:44 UTC) #5
Marc Treib
lgtm
4 years, 6 months ago (2016-06-10 10:35:00 UTC) #6
blundell
lgtm, thanks!
4 years, 6 months ago (2016-06-10 10:38:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052213002/1
4 years, 6 months ago (2016-06-10 11:14:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 11:46:19 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 11:46:24 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:48:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f8b53fd1b00bc82609c731bfea77e50cd123d51
Cr-Commit-Position: refs/heads/master@{#399157}

Powered by Google App Engine
This is Rietveld 408576698