[Material][Mac] Replace the default favicon with a vector

[Material][Mac] Replace the default favicon with a vector

BUG=618742
Committed: https://crrev.com/b2557875f1783f455212f45fdd85fcd3af9b35f6
Cr-Commit-Position: refs/heads/master@{#399930}

[spqchan, 2016-06-09 23:51:22]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-06-09 23:51:22]

PTAL

[spqchan, 2016-06-13 23:47:36]

PTAL

Thanks for the CL! I applied your changes here and fixed some nits

[shrike, 2016-06-14 00:29:42]

Thank you for fixing the nit!

lgtm, at least on my tower. It should be OK on Retina. I have to do a full build
there to check so it'll take awhile. I'll start it compiling once I get home and
let you know tonight how it goes.

[shrike, 2016-06-14 04:22:42]

I looked at this patch on my Retina machine and the line edges were fuzzy. I
made a couple changes to fix that, which I added to my cl 2068533002. With those
changes, this cl should work well on Retina and non-Retina.

[spqchan, 2016-06-14 17:47:39]

Added your second patch.

[spqchan, 2016-06-14 19:53:10]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-06-14 19:53:11]

+rsesek for OWNERS

[shrike, 2016-06-14 21:22:51]

lgtm

[Robert Sesek, 2016-06-14 21:29:00]

LGTM

https://codereview.chromium.org/2052153002/diff/90001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm (right):

https://codereview.chromium.org/2052153002/diff/90001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm:28: +
(NSImage*)imageForColor:(SkColor)strokeCOlor;
nit: capitalized O in COlor

[spqchan, 2016-06-15 01:35:08]

Thanks!

https://codereview.chromium.org/2052153002/diff/90001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm (right):

https://codereview.chromium.org/2052153002/diff/90001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm:28: +
(NSImage*)imageForColor:(SkColor)strokeCOlor;
On 2016/06/14 21:29:00, Robert Sesek wrote:
> nit: capitalized O in COlor

Done.

[spqchan, 2016-06-15 01:35:12]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-06-15 01:35:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
shrike@chromium.org
Link to the patchset: https://codereview.chromium.org/2052153002/#ps110001
(title: "nit")

[commit-bot: I haz the power, 2016-06-15 01:35:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052153002/110001

[commit-bot: I haz the power, 2016-06-15 03:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 03:36:25]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[spqchan, 2016-06-15 17:00:25]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-06-15 17:01:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052153002/110001

[commit-bot: I haz the power, 2016-06-15 17:06:36]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2016-06-15 17:06:59]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 17:08:12]

Description was changed from

==========
[Material][Mac] Replace the default favicon with a vector

BUG=618742
==========

to

==========
[Material][Mac] Replace the default favicon with a vector

BUG=618742

Committed: https://crrev.com/b2557875f1783f455212f45fdd85fcd3af9b35f6
Cr-Commit-Position: refs/heads/master@{#399930}
==========

[commit-bot: I haz the power, 2016-06-15 17:08:13]

Patchset 7 (id:??) landed as
https://crrev.com/b2557875f1783f455212f45fdd85fcd3af9b35f6
Cr-Commit-Position: refs/heads/master@{#399930}