Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 205213006: Fix pixel snapping of clipLayers and their descendants (Closed)

Created:
6 years, 9 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Fix pixel snapping of clipLayers and their descendants Hopefully the last in a line of compositing sub-pixel patches. This correctly pixel snaps the clipping layer used by composited layers with overflow: clip and accumulates it into their children. BUG=347521 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M LayoutTests/compositing/repaint/should-not-repaint-composited-styles-expected.txt View 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/sub-pixel/nested-sub-pixel-composited-layers.html View 1 chunk +14 lines, -7 lines 0 comments Download
M LayoutTests/fast/sub-pixel/nested-sub-pixel-composited-layers-expected.html View 2 chunks +10 lines, -4 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
leviw_travelin_and_unemployed
Last of the sub-pixel compositing bugs for awhile (I hope!!)
6 years, 9 months ago (2014-03-20 01:08:23 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-20 01:10:09 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-20 01:10:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/205213006/1
6 years, 9 months ago (2014-03-20 01:10:15 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 02:05:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 02:05:32 UTC) #6
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-20 02:32:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/205213006/1
6 years, 9 months ago (2014-03-20 02:32:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 03:41:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 03:41:25 UTC) #10
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-20 03:45:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/205213006/1
6 years, 9 months ago (2014-03-20 03:45:24 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 04:59:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 04:59:38 UTC) #14
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 9 months ago (2014-03-20 05:16:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/205213006/1
6 years, 9 months ago (2014-03-20 05:16:59 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 06:20:59 UTC) #17
Message was sent while issue was closed.
Change committed as 169624

Powered by Google App Engine
This is Rietveld 408576698