media/gpu/android_video_decode_accelerator.h - Issue 2052103002: Enable deferred rendering strategy for Android WebView for Spitzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/android_video_decode_accelerator.h

Issue 2052103002: Enable deferred rendering strategy for Android WebView for Spitzer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@spitzer-aw-disable-tests

Patch Set: Removed test files that we added by mistake Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/filters/gpu_video_decoder.cc ('K') | « media/filters/gpu_video_decoder.cc ('k') | media/gpu/android_video_decode_accelerator.cc » ('j') | media/gpu/android_video_decode_accelerator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/gpu/android_video_decode_accelerator.h

diff --git a/media/gpu/android_video_decode_accelerator.h b/media/gpu/android_video_decode_accelerator.h

index 69cd6d9d6ecefb97501506b78048cf513ed6cff6..d7b7a0ea387093a64e16400f601243567fc8e15b 100644

--- a/media/gpu/android_video_decode_accelerator.h

+++ b/media/gpu/android_video_decode_accelerator.h

@@ -348,10 +348,13 @@ class MEDIA_GPU_EXPORT AndroidVideoDecodeAccelerator

// this.

void OnDestroyingSurface(int surface_id);

- // Return true if and only if we should use deferred rendering.

+ // Returns true if and only if we should use deferred rendering.

static bool UseDeferredRenderingStrategy(

const gpu::GpuPreferences& gpu_preferences);

+ // Returns true if frame's COPY_REQUIRED flag needs to be set.

+ static bool RequiresTextureCopy(const gpu::GpuPreferences& gpu_preferences);

// Used to DCHECK that we are called on the correct thread.

base::ThreadChecker thread_checker_;