Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Issue 2052013002: Adding ChromeLauncherController interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome_launcher_smaller_api
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
similarity index 98%
rename from chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
rename to chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
index abd23f7c33532c2e46cfb422f1aecef4290e3169..eb31c5cb92d9fdabcfb3b5becd4d686c15f1d0f3 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
+#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h"
#include <stddef.h>
@@ -83,6 +83,11 @@ using content::WebContents;
namespace {
+ChromeLauncherControllerImpl* GetChromeLauncherControllerImpl() {
+ return static_cast<ChromeLauncherControllerImpl*>(
+ ChromeLauncherController::instance());
+}
+
class TestEvent : public ui::Event {
public:
explicit TestEvent(ui::EventType type)
@@ -188,7 +193,7 @@ class LauncherPlatformAppBrowserTest
void RunTestOnMainThreadLoop() override {
shelf_ = ash::Shelf::ForPrimaryDisplay();
- controller_ = ChromeLauncherController::instance();
+ controller_ = GetChromeLauncherControllerImpl();
return extensions::PlatformAppBrowserTest::RunTestOnMainThreadLoop();
}
@@ -237,7 +242,7 @@ class LauncherPlatformAppBrowserTest
}
ash::Shelf* shelf_;
- ChromeLauncherController* controller_;
+ ChromeLauncherControllerImpl* controller_;
private:
@@ -265,7 +270,7 @@ class ShelfAppBrowserTest : public ExtensionBrowserTest {
void RunTestOnMainThreadLoop() override {
shelf_ = ash::Shelf::ForPrimaryDisplay();
model_ = ash::test::ShellTestApi(ash::Shell::GetInstance()).shelf_model();
- controller_ = ChromeLauncherController::instance();
+ controller_ = GetChromeLauncherControllerImpl();
return ExtensionBrowserTest::RunTestOnMainThreadLoop();
}
@@ -389,10 +394,9 @@ class ShelfAppBrowserTest : public ExtensionBrowserTest {
ash::Shelf* shelf_;
ash::ShelfModel* model_;
- ChromeLauncherController* controller_;
+ ChromeLauncherControllerImpl* controller_;
private:
-
DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserTest);
};
@@ -900,9 +904,9 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchInBackground) {
LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_TAB,
NEW_BACKGROUND_TAB);
EXPECT_EQ(++tab_count, tab_strip->count());
- ChromeLauncherController::instance()->LaunchApp(last_loaded_extension_id(),
- ash::LAUNCH_FROM_UNKNOWN,
- 0);
+ controller_->LaunchApp(last_loaded_extension_id(),
+ ash::LAUNCH_FROM_UNKNOWN,
+ 0);
}
// Confirm that clicking a icon for an app running in one of 2 maxmized windows
@@ -942,13 +946,13 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ActivateApp) {
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("app1"));
- ChromeLauncherController::instance()->ActivateApp(extension->id(),
- ash::LAUNCH_FROM_UNKNOWN,
- 0);
+ controller_->ActivateApp(extension->id(),
+ ash::LAUNCH_FROM_UNKNOWN,
+ 0);
EXPECT_EQ(++tab_count, tab_strip->count());
- ChromeLauncherController::instance()->ActivateApp(extension->id(),
- ash::LAUNCH_FROM_UNKNOWN,
- 0);
+ controller_->ActivateApp(extension->id(),
+ ash::LAUNCH_FROM_UNKNOWN,
+ 0);
EXPECT_EQ(tab_count, tab_strip->count());
}
@@ -959,13 +963,13 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchApp) {
const Extension* extension =
LoadExtension(test_data_dir_.AppendASCII("app1"));
- ChromeLauncherController::instance()->LaunchApp(extension->id(),
- ash::LAUNCH_FROM_UNKNOWN,
- 0);
+ controller_->LaunchApp(extension->id(),
+ ash::LAUNCH_FROM_UNKNOWN,
+ 0);
EXPECT_EQ(++tab_count, tab_strip->count());
- ChromeLauncherController::instance()->LaunchApp(extension->id(),
- ash::LAUNCH_FROM_UNKNOWN,
- 0);
+ controller_->LaunchApp(extension->id(),
+ ash::LAUNCH_FROM_UNKNOWN,
+ 0);
EXPECT_EQ(++tab_count, tab_strip->count());
}

Powered by Google App Engine
This is Rietveld 408576698