chrome/browser/extensions/bookmark_app_helper.cc - Issue 2052013002: Adding ChromeLauncherController interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 2052013002: Adding ChromeLauncherController interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@chrome_launcher_smaller_api

Patch Set: Updating comment. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/bookmark_app_helper.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc

index 737603531cc544d5c74ee1eb92472ef05b80aaea..24408f06aaea67170387e02b7c0bf05fc160327e 100644

--- a/chrome/browser/extensions/bookmark_app_helper.cc

+++ b/chrome/browser/extensions/bookmark_app_helper.cc

@@ -72,7 +72,8 @@

#endif // defined(OS_WIN)

#if defined(USE_ASH)

-#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"

+#include "ash/shelf/shelf_delegate.h"

+#include "ash/shell.h"

#endif

namespace {

@@ -716,7 +717,7 @@ void BookmarkAppHelper::FinishInstallation(const Extension* extension) {

web_app::CreateShortcuts(web_app::SHORTCUT_CREATION_BY_USER,

creation_locations, current_profile, extension);

#else

- ChromeLauncherController::instance()->PinAppWithID(extension->id());

+ ash::Shell::GetInstance()->GetShelfDelegate()->PinAppWithID(extension->id());

msw 2016/06/10 19:24:58 We should avoid adding Shell::GetInstance calls to

#endif // !defined(USE_ASH)

#endif // !defined(OS_MACOSX)

« no previous file with comments | « no previous file | chrome/browser/ui/app_list/arc/arc_app_list_prefs.h » ('j') | chrome/browser/ui/ash/app_list/app_list_controller_ash.cc » ('J')