Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2052003006: More YVU_420 buffers support. (Closed)

Created:
4 years, 6 months ago by Daniele Castagna
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More YUV_420 buffers support. This CL adds: - YVU_420 to the list of native formats supported by BrowserGPuMemoryBufferManager. - YVU_420 to the list of native formats supported by ClientNativePixmapFactory. - GL_RGB_YCRCB_420_CHROMIUM as a valid internal format when creating an image. - A logging statement in exo::Buffer in case an image fails to be created. Additionally, this CL let GbmPixmap::ExportHandle to export buffers with less fds than planes as discussed in crrev.com/2055483002 BUG=crbug.com/618516 TEST=Manually tested creating a fake YV12 buffer in exo::Display::CreateLinuxDMABufBuffer. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/2db83c7ef2e6fd558afb88c3017dc732f369da02 Cr-Commit-Position: refs/heads/master@{#399597}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address dnicoara's comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M components/exo/buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Daniele Castagna
4 years, 6 months ago (2016-06-11 00:06:51 UTC) #3
reveman
lgtm
4 years, 6 months ago (2016-06-11 00:10:03 UTC) #4
Daniele Castagna
Adding owners: +dnicoara for ui/ozone/* +sievers for content/* and gpu/*
4 years, 6 months ago (2016-06-11 00:11:44 UTC) #7
dnicoara
lgtm https://codereview.chromium.org/2052003006/diff/1/ui/ozone/platform/drm/gpu/gbm_buffer.cc File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2052003006/diff/1/ui/ozone/platform/drm/gpu/gbm_buffer.cc#newcode167 ui/ozone/platform/drm/gpu/gbm_buffer.cc:167: if (i < buffer_->GetFdCount()) { nit: Would you ...
4 years, 6 months ago (2016-06-13 13:41:18 UTC) #8
Daniele Castagna
https://codereview.chromium.org/2052003006/diff/1/ui/ozone/platform/drm/gpu/gbm_buffer.cc File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right): https://codereview.chromium.org/2052003006/diff/1/ui/ozone/platform/drm/gpu/gbm_buffer.cc#newcode167 ui/ozone/platform/drm/gpu/gbm_buffer.cc:167: if (i < buffer_->GetFdCount()) { On 2016/06/13 at 13:41:17, ...
4 years, 6 months ago (2016-06-13 17:07:59 UTC) #9
no sievers
lgtm
4 years, 6 months ago (2016-06-13 18:12:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052003006/20001
4 years, 6 months ago (2016-06-13 18:22:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 23:33:35 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 23:33:39 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 23:34:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2db83c7ef2e6fd558afb88c3017dc732f369da02
Cr-Commit-Position: refs/heads/master@{#399597}

Powered by Google App Engine
This is Rietveld 408576698