Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2051953002: [css-grid] Avoid unneeded calls to percentageLogicalHeightIsResolvable() (Closed)

Created:
4 years, 6 months ago by Manuel Rego
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Avoid unneeded calls to percentageLogicalHeightIsResolvable() r398535 was introducing a performance regression on grid layout tests. The problem is that it was calling LayoutGrid::hasDefiniteLogicalSize() which was very slow. r398680 was getting rid of hasDefiniteLogicalSize() and replacing it by calls to LayoutBox::percentageLogicalHeightIsResolvable(). Despite being faster it's still an expensive operation and we don't need to do it always. So in this patch we're avoid calling percentageLogicalHeightIsResolvable() when the min and max track breadths are not percentages. BUG=618664, 616716 Committed: https://crrev.com/06fdd11aadb98dd6e25c6aaace831998b23eae86 Cr-Commit-Position: refs/heads/master@{#399130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Manuel Rego
This CL should be fixing the perf regression. It's the same that fixed the regression ...
4 years, 6 months ago (2016-06-09 21:02:06 UTC) #2
cbiesinger
lgtm
4 years, 6 months ago (2016-06-09 22:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051953002/1
4 years, 6 months ago (2016-06-10 05:26:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/85663)
4 years, 6 months ago (2016-06-10 06:34:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051953002/1
4 years, 6 months ago (2016-06-10 06:56:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 07:24:05 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 07:24:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 07:25:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06fdd11aadb98dd6e25c6aaace831998b23eae86
Cr-Commit-Position: refs/heads/master@{#399130}

Powered by Google App Engine
This is Rietveld 408576698