Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2051923002: Motown: Fix unique_ptrs to arrays so deallocation is done properly (Closed)

Created:
4 years, 6 months ago by dalesat
Modified:
4 years, 6 months ago
Reviewers:
kulakowski, johngro
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Motown: Fix unique_ptrs to arrays so deallocation is done properly We're getting deallocation errors on shutdown indicating that memory allocated with new[] is being deallocated with delete (rather than delete[]). This CL fixes the type of some unique_ptrs to address this. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/369e050775bc85d9288a50c56e896f267d6339cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M services/media/audio/platform/generic/standard_output_base.h View 1 chunk +1 line, -1 line 0 comments Download
M services/media/audio/platform/generic/standard_output_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/media/audio/platform/linux/alsa_output.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
dalesat
Easy one...please take a look. Thanks!
4 years, 6 months ago (2016-06-09 19:05:38 UTC) #3
kulakowski
On 2016/06/09 19:05:38, dalesat wrote: > Easy one...please take a look. Thanks! lgtm
4 years, 6 months ago (2016-06-09 19:07:17 UTC) #4
dalesat
4 years, 6 months ago (2016-06-09 19:11:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
369e050775bc85d9288a50c56e896f267d6339cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698