Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2051853002: Measure queueing and blocking time for touchstart/touchend. (Closed)

Created:
4 years, 6 months ago by tdresser
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure queueing and blocking time for touchstart/touchend. Adds histograms for Event.Latency.QueueingTime.TouchStartDefaultPrevented Event.Latency.QueueingTime.TouchStartDefaultAllowed Event.Latency.BlockingTime.TouchStartDefaultPrevented Event.Latency.BlockingTime.TouchStartDefaultAllowed Event.Latency.QueueingTime.TouchEndDefaultPrevented Event.Latency.QueueingTime.TouchEndDefaultAllowed Event.Latency.BlockingTime.TouchEndDefaultPrevented Event.Latency.BlockingTime.TouchEndDefaultAllowed BUG=600730 TEST=RenderWidgetHostLatencyTrackerTest.TouchBlockingAndQueueingTime Committed: https://crrev.com/018817f3af66b9c084982cb3944d2ce585d00370 Cr-Commit-Position: refs/heads/master@{#399522}

Patch Set 1 #

Patch Set 2 : Update histograms.xml, fix microseconds -> ms. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -60 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 2 chunks +89 lines, -20 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 1 chunk +164 lines, -34 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 6 chunks +78 lines, -6 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051853002/1
4 years, 6 months ago (2016-06-09 14:47:06 UTC) #2
tdresser
+isherman@ for tools/metrics/histograms/histograms.xml +aelias@ for content/browser/renderer_host/input/render_widget_host_latency_tracker*
4 years, 6 months ago (2016-06-09 16:54:08 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 6 months ago (2016-06-09 18:31:50 UTC) #5
Ilya Sherman
LGTM, though you're adding quite a few histograms here. Please make sure to come back ...
4 years, 6 months ago (2016-06-10 23:22:37 UTC) #6
tdresser
On 2016/06/10 23:22:37, Ilya Sherman wrote: > LGTM, though you're adding quite a few histograms ...
4 years, 6 months ago (2016-06-13 18:29:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2051853002/20001
4 years, 6 months ago (2016-06-13 18:30:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 20:23:16 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 20:23:24 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:24:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/018817f3af66b9c084982cb3944d2ce585d00370
Cr-Commit-Position: refs/heads/master@{#399522}

Powered by Google App Engine
This is Rietveld 408576698